chore: marked step 5 as complete

This commit is contained in:
2026-04-28 19:00:23 +02:00
parent 2f09bf527d
commit 0f3c1e12c1

12
PLAN.md
View File

@@ -59,8 +59,8 @@ Only these two audit tracks matter for the current pass. Import and menu stay ou
4. Implement the shared modal and confirmation layer. Completed 2026-04-26.
The LiveView shell now owns the shared modal/overlay system required by the specs: AI suggestions, delete confirmations, merge confirmation, picker overlays, and gallery/lightbox flows, with overlay state isolated in a pure module and covered by focused tests.
5. Audit batch 3: shell UI plus all dedicated editors already present.
Compare the old Electron/React shell and each dedicated editor route against the current LiveView shell, score parity green/yellow/red, and emit only the concrete drift list for the slices that still differ.
5. Audit batch 3: shell UI plus all dedicated editors already present. Completed 2026-04-28.
Compared the old Electron/React shell and each dedicated editor route against the current LiveView shell, scored parity green/yellow/red, and reduced the proven batch-3 drift list to the remaining chat-surface gaps only.
6. Audit batch 4: lower-risk backend and integration services behind those surfaces.
Tie each old engine contract to its bDS2 replacement, verify the executable proof set, probe the service through the owning UI/editor entry points where applicable, and emit only the behavior drifts that remain.
@@ -68,8 +68,8 @@ Only these two audit tracks matter for the current pass. Import and menu stay ou
7. Restore chat editor parity on the implemented route.
Bring the current chat tab up to old bDS for the implemented conversation UI: add model selection, streaming turn state, tool-call/result presentation, and A2UI surface rendering to the existing persisted-transcript editor without widening into unrelated AI features.
8. Restore misc maintenance editor parity on the implemented routes.
Upgrade translation validation from raw issue lists to the old dedicated validate-and-fix surface, and replace plain-text git diff rendering with a structured diff viewer, while keeping the current metadata-diff, site-validation, and duplicate flows intact.
8. Restore misc maintenance editor parity on the implemented routes. Completed 2026-04-28.
Translation validation now uses the old dedicated validate-and-fix card surface again, and git diff now renders through the structured Monaco diff viewer while keeping the current metadata-diff, site-validation, and duplicate flows intact.
9. Fix any remaining batch 3 and batch 4 parity gaps that the audit proves.
Do not widen into import/menu/release-packaging work unless one of those blocks a batch 3 or batch 4 parity scenario.
@@ -112,8 +112,8 @@ Current batch 3 parity scores for existing implemented UI/editor code only. Miss
| Tags editor | green | `src/renderer/components/TagsView/TagsView.tsx` | `lib/bds/desktop/shell_live/tags_editor.ex`, `lib/bds/desktop/shell_live/tags_editor_html/*` | `mix test test/bds/desktop/shell_live_test.exs`; tags editor implementation compared | No material implemented-code parity drift found in the current create/edit/delete/merge flows, color handling, or post-template selection behavior. |
| Script editor | green | `src/renderer/components/ScriptsView/ScriptsView.tsx` | `lib/bds/desktop/shell_live/code_entity_editor.ex`, `lib/bds/desktop/shell_live/code_entity_editor_html/script_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; script editor implementation compared | No material implemented-code parity drift found in the current Monaco editor, metadata form, syntax check, run, save, delete, and entrypoint selection flow. |
| Template editor | green | `src/renderer/components/TemplatesView/TemplatesView.tsx` | `lib/bds/desktop/shell_live/code_entity_editor.ex`, `lib/bds/desktop/shell_live/code_entity_editor_html/template_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; template editor implementation compared | No material implemented-code parity drift found in the current Monaco editor, metadata form, validate, save, and delete flow. |
| Chat editor | yellow | `src/renderer/components/ChatPanel/ChatPanel.tsx` | `lib/bds/desktop/shell_live/chat_editor.ex`, `lib/bds/desktop/shell_live/chat_editor_html/chat_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; chat editor implementation compared | The current bDS2 chat route works, but it is materially thinner than old bDS: bDS2 renders a simple persisted transcript and textarea, while old bDS also exposes model selection, streaming turn state, tool-call/result presentation, and A2UI surfaces. |
| Misc maintenance editors | yellow | `src/renderer/components/SiteValidationView`, `TranslationValidationView`, `MetadataDiffPanel`, `DuplicatesView`, `GitDiffView` | `lib/bds/desktop/shell_live/misc_editor.ex`, `lib/bds/desktop/shell_live/misc_editor_html/misc_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; misc editor implementation compared | The consolidated misc route is strong for metadata diff, site validation, and duplicate dismissal, but two implemented sub-surfaces are materially thinner than old bDS: translation validation is reduced to raw issue lists with no dedicated fix/revalidate UI, and git diff is rendered as plain preformatted text instead of a structured diff viewer. |
| Chat editor | yellow | `src/renderer/components/ChatPanel/ChatPanel.tsx` | `lib/bds/desktop/shell_live/chat_editor.ex`, `lib/bds/desktop/shell_live/chat_editor_html/chat_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; chat editor implementation compared | The current bDS2 chat route now covers the old model selector, welcome state, persisted transcript, airplane-mode gating, tool markers, and structured tool surfaces, but it is still materially thinner than old bDS in the live-turn path: no streaming state/stop flow, no markdown transcript rendering, no API-key-required screen, and no A2UI action surface dispatch yet. |
| Misc maintenance editors | green | `src/renderer/components/SiteValidationView`, `TranslationValidationView`, `MetadataDiffPanel`, `DuplicatesView`, `GitDiffView` | `lib/bds/desktop/shell_live/misc_editor.ex`, `lib/bds/desktop/shell_live/misc_editor_html/misc_editor.html.heex` | `mix test test/bds/desktop/shell_live_test.exs`; misc editor implementation compared | No material implemented-code parity drift found in the current metadata diff, site validation, duplicate dismissal, translation validation, or working-tree git diff flows. Translation validation again uses dedicated issue cards with revalidate/fix actions, and git diff now uses the structured Monaco diff surface. |
## Batch 4 Audit Matrix