Markdown rendering of comment text #50

New Issue

hugo · 2026-08-01T12:57:24Z

hugo commented

2026-08-01 12:57:24 +00:00

Comment text is not properly markdown rendered - two paragraphs are rendered as one big text on issue text.

Use this issue as reference, it is showing as one block but is multiple paragraphs.

Are lists working?

first line
second line

Comment text is not properly markdown rendered - two paragraphs are rendered as one big text on issue text. Use this issue as reference, it is showing as one block but is multiple paragraphs. Are lists working? - first line - second line

hugo added this to the first feature complete release milestone 2026-08-01 12:57:39 +00:00

hugo added the bug critical labels 2026-08-01 12:57:39 +00:00

hugo commented

2026-08-01 13:24:45 +00:00

Implemented in d0ec533.

The broken renderer was Foundation AttributedString(markdown:): it retained block structure only as presentation metadata, so conversion to NSAttributedString concatenated paragraphs and list items.

Reused the existing MarkdownUI GitHub-theme presentation from repository file Preview as the single MarkdownContent renderer.
Routed issue and pull-request descriptions/comments, milestone descriptions, and commit descriptions through that shared renderer; single-line titles remain native labels.
Preserved text selection, Dynamic Type, VoiceOver semantics, links, paragraphs, lists, and inline formatting.
Removed the superseded Foundation Markdown helper and updated TESTING.md for every affected surface.

Verification:

cargo fmt --all -- --check
RUSTFLAGS="-D warnings" cargo check --workspace --all-targets
cargo clippy --workspace --all-targets -- -D warnings
cargo test --workspace (31 tests passed)
Signed iPhone 17 Pro Simulator build passed.
Issue #50 renders its three paragraphs and two-item list as separate blocks at normal and largest accessibility text sizes; VoiceOver exposes each block/list item separately.
A live milestone description rendered a bold paragraph and bullet list using the same presentation, then was restored exactly to its original server value.

Implemented in `d0ec533`. The broken renderer was Foundation `AttributedString(markdown:)`: it retained block structure only as presentation metadata, so conversion to `NSAttributedString` concatenated paragraphs and list items. - Reused the existing MarkdownUI GitHub-theme presentation from repository file Preview as the single `MarkdownContent` renderer. - Routed issue and pull-request descriptions/comments, milestone descriptions, and commit descriptions through that shared renderer; single-line titles remain native labels. - Preserved text selection, Dynamic Type, VoiceOver semantics, links, paragraphs, lists, and inline formatting. - Removed the superseded Foundation Markdown helper and updated `TESTING.md` for every affected surface. Verification: - `cargo fmt --all -- --check` - `RUSTFLAGS="-D warnings" cargo check --workspace --all-targets` - `cargo clippy --workspace --all-targets -- -D warnings` - `cargo test --workspace` (31 tests passed) - Signed iPhone 17 Pro Simulator build passed. - Issue #50 renders its three paragraphs and two-item list as separate blocks at normal and largest accessibility text sizes; VoiceOver exposes each block/list item separately. - A live milestone description rendered a bold paragraph and bullet list using the same presentation, then was restored exactly to its original server value.

hugo closed this issue

2026-08-01 13:25:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hugo/Gotcha#50