do a full review of the source for quality #24
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Make sure that the version of the appllication is 1.0, this is the first public release and should have that version. Earlier things should only raise the build number until the first published release.
The full functionality of the app, the actual code that executes function needs to be Rust. Swift is only there to handle the UI itself. So the code has to be reviewed to make sure that we not only follow best practices for both Rust and Swift, but also make sure that Swift code is really only handling the UI areas and we don't put functionality into Swift "just because that file was open". there is a deliberate decision on where code has to be done and we must follow that.
Also the code needs to be reviewed for duplications and god-files with too many lines. The target length is below 500 lines. There need to be very good reasons to go above those lines and those reasons must be documented.
The full UI has to be tested and evaluated with regards to Apple human interface guidelines that all elements follow the actual structure how the application is supposed to be working. This includes behaviour with light and dark themes, check that all screens have proper contrast. also make sure that liquid glass is followed so the app behaves like users expect of a modern app. Align the rust crate version to this version.
make sure that proper signing is active and that the app is ready for iOS app store submission. This is not a test application anymore, it is the full thing, meant to go to users.