chore: moved a bunch of bridges out of the ShellLive module into its own

module

lib/bds/desktop/shell_live.ex

@@ -10,6 +10,7 @@ defmodule BDS.Desktop.ShellLive do
   alias BDS.Desktop.{FolderPicker, ShellData, UILocale}
 
   alias BDS.Desktop.ShellLive.{
+    Bridges,
     ChatEditor,
     ImportEditor,
     MediaEditor,
@@ -31,7 +32,6 @@ defmodule BDS.Desktop.ShellLive do
 
   alias BDS.Desktop.ShellLive.{
     ChatSurface,
-    CliSync,
     Layout,
     SessionUtil,
     ShellCommandRunner,
@@ -503,215 +503,6 @@ defmodule BDS.Desktop.ShellLive do
     {:noreply, next_socket}
   end
 
-  def handle_info({:import_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:import_editor_tab_meta, definition_id, title, subtitle}, socket) do
-    tab_meta =
-      Map.put(socket.assigns.tab_meta, {:import, definition_id}, %{
-        title: title,
-        subtitle: subtitle || ""
-      })
-
-    {:noreply,
-     socket
-     |> assign(:tab_meta, tab_meta)
-     |> reload_shell(socket.assigns.workbench)}
-  end
-
-  def handle_info({:chat_tool_call, conversation_id, tool_call}, socket) do
-    send_update(ChatEditor,
-      id: "chat-editor-#{conversation_id}",
-      action: :note_tool_call,
-      tool_call: tool_call
-    )
-
-    {:noreply, socket}
-  end
-
-  def handle_info({:chat_tool_result, conversation_id, name}, socket) do
-    send_update(ChatEditor,
-      id: "chat-editor-#{conversation_id}",
-      action: :note_tool_result,
-      name: name
-    )
-
-    {:noreply, socket}
-  end
-
-  def handle_info({:chat_streaming_content, conversation_id, content}, socket) do
-    send_update(ChatEditor,
-      id: "chat-editor-#{conversation_id}",
-      action: :note_streaming_content,
-      content: content
-    )
-
-    {:noreply, socket}
-  end
-
-  def handle_info({:chat_editor_task_started, conversation_id, ref}, socket) do
-    refs = Map.put(socket.assigns.chat_editor_request_refs, ref, conversation_id)
-    {:noreply, assign(socket, :chat_editor_request_refs, refs)}
-  end
-
-  def handle_info({:chat_editor_task_cancelled, _conversation_id, ref}, socket) do
-    refs = Map.delete(socket.assigns.chat_editor_request_refs, ref)
-    {:noreply, assign(socket, :chat_editor_request_refs, refs)}
-  end
-
-  def handle_info({:chat_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:chat_editor_tab_meta, conversation_id, title, subtitle}, socket) do
-    tab_meta =
-      Map.put(socket.assigns.tab_meta, {:chat, conversation_id}, %{
-        title: title,
-        subtitle: subtitle || ""
-      })
-
-    {:noreply,
-     socket
-     |> assign(:tab_meta, tab_meta)
-     |> reload_shell(socket.assigns.workbench)}
-  end
-
-  def handle_info({:open_sidebar_item, params, intent}, socket) do
-    {:noreply, open_sidebar_item(socket, params, intent)}
-  end
-
-  def handle_info({:chat_editor_toggle_sidebar}, socket) do
-    {:noreply, reload_shell(socket, Workbench.toggle_sidebar(socket.assigns.workbench))}
-  end
-
-  def handle_info({:chat_editor_toggle_panel}, socket) do
-    {:noreply, reload_shell(socket, Workbench.toggle_panel(socket.assigns.workbench))}
-  end
-
-  def handle_info({:chat_editor_toggle_assistant_sidebar}, socket) do
-    {:noreply, reload_shell(socket, Workbench.toggle_assistant_sidebar(socket.assigns.workbench))}
-  end
-
-  def handle_info({:chat_editor_switch_view, view}, socket) do
-    {:noreply, reload_shell(socket, Workbench.click_activity(socket.assigns.workbench, view))}
-  end
-
-  def handle_info({:entity_changed, payload}, socket) when is_map(payload) do
-    {:noreply, CliSync.apply_entity_change(socket, payload, &reload_shell/2)}
-  end
-
-  def handle_info(:refresh_task_status, socket) do
-    raw_task_status = BDS.Tasks.status_snapshot()
-
-    case SessionUtil.next_completed_task_result(socket, raw_task_status) do
-      nil ->
-        task_status = localize_task_status(raw_task_status, socket.assigns.page_language)
-
-        {:noreply,
-         socket
-         |> assign(:task_status, task_status)
-         |> assign(:editor_meta, ShellData.editor_meta(task_status))
-         |> assign(
-           :status,
-           ShellData.status_bar(socket.assigns.workbench, task_status, socket.assigns.dashboard,
-             ui_language: socket.assigns.page_language,
-             offline_mode: socket.assigns.offline_mode
-           )
-         )}
-
-      task ->
-        {:noreply,
-         socket
-         |> SessionUtil.mark_task_result_handled(task.id)
-         |> apply_shell_command_result(task.result)}
-    end
-  end
-
-  def handle_info({:tags_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info(:tags_changed, socket) do
-    {:noreply, reload_shell(socket, socket.assigns.workbench)}
-  end
-
-  def handle_info({:settings_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info(:settings_changed, socket) do
-    {:noreply, reload_shell(socket, socket.assigns.workbench)}
-  end
-
-  def handle_info({:menu_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:script_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:template_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:misc_editor_output, title, message, _detail, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:misc_editor_command, action, params}, socket) do
-    {:noreply, apply_shell_command(socket, action, params)}
-  end
-
-  def handle_info({:misc_editor_tab_meta, tab_type, tab_id, updates}, socket) do
-    key = {tab_type, tab_id}
-    current_meta = Map.get(socket.assigns.tab_meta, key, %{})
-    next_meta = Map.merge(current_meta, updates)
-    {:noreply, assign(socket, :tab_meta, Map.put(socket.assigns.tab_meta, key, next_meta))}
-  end
-
-  def handle_info({:post_editor_output, title, message, level}, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
-  end
-
-  def handle_info({:post_editor_dirty, post_id, dirty?}, socket) do
-    workbench =
-      if dirty? do
-        BDS.UI.Workbench.mark_dirty(socket.assigns.workbench, :post, post_id)
-      else
-        BDS.UI.Workbench.clear_dirty(socket.assigns.workbench, :post, post_id)
-      end
-
-    {:noreply, assign(socket, :workbench, workbench)}
-  end
-
-  def handle_info({:post_editor_tab_meta, post_id, title, subtitle}, socket) do
-    tab_meta =
-      Map.put(socket.assigns.tab_meta, {:post, post_id}, %{title: title, subtitle: subtitle})
-
-    {:noreply, assign(socket, :tab_meta, tab_meta)}
-  end
-
-  def handle_info({:post_editor_insert_content, post_id, content}, socket) do
-    send_update(PostEditor, id: "post-editor-#{post_id}", action: :insert_content, content: content)
-    {:noreply, socket}
-  end
-
-  def handle_info({:post_editor_translate, post_id, language}, socket) do
-    send_update(PostEditor, id: "post-editor-#{post_id}", action: :translate, language: language)
-    {:noreply, socket}
-  end
-
-  def handle_info({:post_editor_apply_ai_suggestions, post_id, fields}, socket) do
-    send_update(PostEditor, id: "post-editor-#{post_id}",
-      action: :apply_ai_suggestions,
-      fields: fields
-    )
-
-    {:noreply, socket}
-  end
-
   def handle_info({:ai_suggestions_result, type, id, result}, socket) do
     OverlayManager.handle_info({:ai_suggestions_result, type, id, result}, socket)
   end
@@ -720,34 +511,8 @@ defmodule BDS.Desktop.ShellLive do
     OverlayManager.handle_info({:ai_suggestions_error, type, id, reason}, socket)
   end
 
-  def handle_info({:media_editor_output, title, message, level}, socket) do
+  def handle_info(message, socket) do
-    {:noreply, append_output_entry(socket, title, message, nil, level)}
+    Bridges.handle_info(message, socket, bridges_callbacks())
-  end
-
-  def handle_info({:media_editor_dirty, media_id, dirty?}, socket) do
-    workbench =
-      if dirty? do
-        Workbench.mark_dirty(socket.assigns.workbench, :media, media_id)
-      else
-        Workbench.clear_dirty(socket.assigns.workbench, :media, media_id)
-      end
-
-    {:noreply, assign(socket, :workbench, workbench)}
-  end
-
-  def handle_info({:media_editor_tab_meta, media_id, title, subtitle}, socket) do
-    tab_meta =
-      Map.put(socket.assigns.tab_meta, {:media, media_id}, %{title: title, subtitle: subtitle})
-
-    {:noreply, assign(socket, :tab_meta, tab_meta)}
-  end
-
-  def handle_info(:reload_shell, socket) do
-    {:noreply, reload_shell(socket, socket.assigns.workbench)}
-  end
-
-  def handle_info({:close_tab, type, id}, socket) do
-    {:noreply, reload_shell(socket, BDS.UI.Workbench.close_tab(socket.assigns.workbench, type, id))}
   end
 
   @impl true
@@ -1087,4 +852,13 @@ defmodule BDS.Desktop.ShellLive do
       append_output: &append_output_entry/5
     }
 
+  defp bridges_callbacks,
+    do: %{
+      reload: &reload_shell/2,
+      append_output: &append_output_entry/5,
+      open_sidebar: &open_sidebar_item/3,
+      apply_shell_command: &apply_shell_command/3,
+      apply_shell_command_result: &apply_shell_command_result/2
+    }
+
 end

lib/bds/desktop/shell_live/bridges.ex

@@ -0,0 +1,262 @@
+defmodule BDS.Desktop.ShellLive.Bridges do
+  @moduledoc false
+
+  import Phoenix.Component, only: [assign: 3]
+  import Phoenix.LiveView, only: [send_update: 2]
+
+  alias BDS.Desktop.ShellData
+  alias BDS.Desktop.ShellLive.{ChatEditor, PostEditor}
+  alias BDS.Desktop.ShellLive.{CliSync, SessionUtil}
+  alias BDS.UI.Workbench
+
+  @spec handle_info(tuple() | atom(), Phoenix.LiveView.Socket.t(), map()) ::
+          {:noreply, Phoenix.LiveView.Socket.t()}
+  def handle_info({:import_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:import_editor_tab_meta, definition_id, title, subtitle}, socket, callbacks) do
+    tab_meta =
+      Map.put(socket.assigns.tab_meta, {:import, definition_id}, %{
+        title: title,
+        subtitle: subtitle || ""
+      })
+
+    {:noreply,
+     socket
+     |> assign(:tab_meta, tab_meta)
+     |> callbacks.reload.(socket.assigns.workbench)}
+  end
+
+  def handle_info({:chat_tool_call, conversation_id, tool_call}, socket, _callbacks) do
+    send_update(ChatEditor,
+      id: "chat-editor-#{conversation_id}",
+      action: :note_tool_call,
+      tool_call: tool_call
+    )
+
+    {:noreply, socket}
+  end
+
+  def handle_info({:chat_tool_result, conversation_id, name}, socket, _callbacks) do
+    send_update(ChatEditor,
+      id: "chat-editor-#{conversation_id}",
+      action: :note_tool_result,
+      name: name
+    )
+
+    {:noreply, socket}
+  end
+
+  def handle_info({:chat_streaming_content, conversation_id, content}, socket, _callbacks) do
+    send_update(ChatEditor,
+      id: "chat-editor-#{conversation_id}",
+      action: :note_streaming_content,
+      content: content
+    )
+
+    {:noreply, socket}
+  end
+
+  def handle_info({:chat_editor_task_started, conversation_id, ref}, socket, _callbacks) do
+    refs = Map.put(socket.assigns.chat_editor_request_refs, ref, conversation_id)
+    {:noreply, assign(socket, :chat_editor_request_refs, refs)}
+  end
+
+  def handle_info({:chat_editor_task_cancelled, _conversation_id, ref}, socket, _callbacks) do
+    refs = Map.delete(socket.assigns.chat_editor_request_refs, ref)
+    {:noreply, assign(socket, :chat_editor_request_refs, refs)}
+  end
+
+  def handle_info({:chat_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:chat_editor_tab_meta, conversation_id, title, subtitle}, socket, callbacks) do
+    tab_meta =
+      Map.put(socket.assigns.tab_meta, {:chat, conversation_id}, %{
+        title: title,
+        subtitle: subtitle || ""
+      })
+
+    {:noreply,
+     socket
+     |> assign(:tab_meta, tab_meta)
+     |> callbacks.reload.(socket.assigns.workbench)}
+  end
+
+  def handle_info({:open_sidebar_item, params, intent}, socket, callbacks) do
+    {:noreply, callbacks.open_sidebar.(socket, params, intent)}
+  end
+
+  def handle_info({:chat_editor_toggle_sidebar}, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, Workbench.toggle_sidebar(socket.assigns.workbench))}
+  end
+
+  def handle_info({:chat_editor_toggle_panel}, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, Workbench.toggle_panel(socket.assigns.workbench))}
+  end
+
+  def handle_info({:chat_editor_toggle_assistant_sidebar}, socket, callbacks) do
+    {:noreply,
+     callbacks.reload.(socket, Workbench.toggle_assistant_sidebar(socket.assigns.workbench))}
+  end
+
+  def handle_info({:chat_editor_switch_view, view}, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, Workbench.click_activity(socket.assigns.workbench, view))}
+  end
+
+  def handle_info({:entity_changed, payload}, socket, callbacks) when is_map(payload) do
+    {:noreply, CliSync.apply_entity_change(socket, payload, callbacks.reload)}
+  end
+
+  def handle_info(:refresh_task_status, socket, callbacks) do
+    raw_task_status = BDS.Tasks.status_snapshot()
+
+    case SessionUtil.next_completed_task_result(socket, raw_task_status) do
+      nil ->
+        task_status =
+          BDS.Desktop.ShellLive.TaskLocalization.localize_task_status(
+            raw_task_status,
+            socket.assigns.page_language
+          )
+
+        {:noreply,
+         socket
+         |> assign(:task_status, task_status)
+         |> assign(:editor_meta, ShellData.editor_meta(task_status))
+         |> assign(
+           :status,
+           ShellData.status_bar(
+             socket.assigns.workbench,
+             task_status,
+             socket.assigns.dashboard,
+             ui_language: socket.assigns.page_language,
+             offline_mode: socket.assigns.offline_mode
+           )
+         )}
+
+      task ->
+        {:noreply,
+         socket
+         |> SessionUtil.mark_task_result_handled(task.id)
+         |> callbacks.apply_shell_command_result.(task.result)}
+    end
+  end
+
+  def handle_info({:tags_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info(:tags_changed, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, socket.assigns.workbench)}
+  end
+
+  def handle_info({:settings_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info(:settings_changed, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, socket.assigns.workbench)}
+  end
+
+  def handle_info({:menu_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:script_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:template_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:misc_editor_output, title, message, _detail, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:misc_editor_command, action, params}, socket, callbacks) do
+    {:noreply, callbacks.apply_shell_command.(socket, action, params)}
+  end
+
+  def handle_info({:misc_editor_tab_meta, tab_type, tab_id, updates}, socket, _callbacks) do
+    key = {tab_type, tab_id}
+    current_meta = Map.get(socket.assigns.tab_meta, key, %{})
+    next_meta = Map.merge(current_meta, updates)
+    {:noreply, assign(socket, :tab_meta, Map.put(socket.assigns.tab_meta, key, next_meta))}
+  end
+
+  def handle_info({:post_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:post_editor_dirty, post_id, dirty?}, socket, _callbacks) do
+    workbench =
+      if dirty? do
+        Workbench.mark_dirty(socket.assigns.workbench, :post, post_id)
+      else
+        Workbench.clear_dirty(socket.assigns.workbench, :post, post_id)
+      end
+
+    {:noreply, assign(socket, :workbench, workbench)}
+  end
+
+  def handle_info({:post_editor_tab_meta, post_id, title, subtitle}, socket, _callbacks) do
+    tab_meta =
+      Map.put(socket.assigns.tab_meta, {:post, post_id}, %{title: title, subtitle: subtitle})
+
+    {:noreply, assign(socket, :tab_meta, tab_meta)}
+  end
+
+  def handle_info({:post_editor_insert_content, post_id, content}, socket, _callbacks) do
+    send_update(PostEditor, id: "post-editor-#{post_id}", action: :insert_content, content: content)
+    {:noreply, socket}
+  end
+
+  def handle_info({:post_editor_translate, post_id, language}, socket, _callbacks) do
+    send_update(PostEditor, id: "post-editor-#{post_id}", action: :translate, language: language)
+    {:noreply, socket}
+  end
+
+  def handle_info({:post_editor_apply_ai_suggestions, post_id, fields}, socket, _callbacks) do
+    send_update(PostEditor, id: "post-editor-#{post_id}",
+      action: :apply_ai_suggestions,
+      fields: fields
+    )
+
+    {:noreply, socket}
+  end
+
+  def handle_info({:media_editor_output, title, message, level}, socket, callbacks) do
+    {:noreply, callbacks.append_output.(socket, title, message, nil, level)}
+  end
+
+  def handle_info({:media_editor_dirty, media_id, dirty?}, socket, _callbacks) do
+    workbench =
+      if dirty? do
+        Workbench.mark_dirty(socket.assigns.workbench, :media, media_id)
+      else
+        Workbench.clear_dirty(socket.assigns.workbench, :media, media_id)
+      end
+
+    {:noreply, assign(socket, :workbench, workbench)}
+  end
+
+  def handle_info({:media_editor_tab_meta, media_id, title, subtitle}, socket, _callbacks) do
+    tab_meta =
+      Map.put(socket.assigns.tab_meta, {:media, media_id}, %{title: title, subtitle: subtitle})
+
+    {:noreply, assign(socket, :tab_meta, tab_meta)}
+  end
+
+  def handle_info(:reload_shell, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, socket.assigns.workbench)}
+  end
+
+  def handle_info({:close_tab, type, id}, socket, callbacks) do
+    {:noreply, callbacks.reload.(socket, Workbench.close_tab(socket.assigns.workbench, type, id))}
+  end
+
+  def handle_info(_message, socket, _callbacks), do: {:noreply, socket}
+end