hugo/bDS2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: cleanup of tmp files for test

Browse Source
This commit is contained in:
Chili Palmer
2026-05-28 22:48:48 +02:00
parent f1265ee326
commit d7e30b94cb
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/bds/csm026_toctou_file_system_test.exs
View File

@@ -3,8 +3,14 @@ defmodule BDS.TOCTOU.FileSystemTest do
alias BDS.Rendering.FileSystem, as: TemplateFileSystem alias BDS.Rendering.FileSystem, as: TemplateFileSystem
setup do
tmp_dir = Path.join(System.tmp_dir!(), "bds-toctou-#{System.unique_integer([:positive])}")
File.mkdir_p!(tmp_dir)
on_exit(fn -> File.rm_rf(tmp_dir) end)
%{tmp_dir: tmp_dir}
end
describe "try_read/2 eliminates TOCTOU race" do describe "try_read/2 eliminates TOCTOU race" do
@tag :tmp_dir
test "reads file atomically without separate existence check", %{tmp_dir: tmp_dir} do test "reads file atomically without separate existence check", %{tmp_dir: tmp_dir} do
File.write!(Path.join(tmp_dir, "header.liquid"), "HEADER CONTENT") File.write!(Path.join(tmp_dir, "header.liquid"), "HEADER CONTENT")
fs = TemplateFileSystem.new(tmp_dir) fs = TemplateFileSystem.new(tmp_dir)
@@ -12,14 +18,12 @@ defmodule BDS.TOCTOU.FileSystemTest do
assert {:ok, "HEADER CONTENT"} = TemplateFileSystem.try_read(fs, "header") assert {:ok, "HEADER CONTENT"} = TemplateFileSystem.try_read(fs, "header")
end end
@tag :tmp_dir
test "returns {:error, :enoent} for missing templates", %{tmp_dir: tmp_dir} do test "returns {:error, :enoent} for missing templates", %{tmp_dir: tmp_dir} do
fs = TemplateFileSystem.new(tmp_dir) fs = TemplateFileSystem.new(tmp_dir)
assert {:error, :enoent} = TemplateFileSystem.try_read(fs, "nonexistent") assert {:error, :enoent} = TemplateFileSystem.try_read(fs, "nonexistent")
end end
@tag :tmp_dir
test "falls through to next root path when first is missing", %{tmp_dir: tmp_dir} do test "falls through to next root path when first is missing", %{tmp_dir: tmp_dir} do
root_a = Path.join(tmp_dir, "a") root_a = Path.join(tmp_dir, "a")
root_b = Path.join(tmp_dir, "b") root_b = Path.join(tmp_dir, "b")
@@ -32,7 +36,6 @@ defmodule BDS.TOCTOU.FileSystemTest do
assert {:ok, "FROM B"} = TemplateFileSystem.try_read(fs, "partial") assert {:ok, "FROM B"} = TemplateFileSystem.try_read(fs, "partial")
end end
@tag :tmp_dir
test "first root path wins when both have the template", %{tmp_dir: tmp_dir} do test "first root path wins when both have the template", %{tmp_dir: tmp_dir} do
root_a = Path.join(tmp_dir, "a") root_a = Path.join(tmp_dir, "a")
root_b = Path.join(tmp_dir, "b") root_b = Path.join(tmp_dir, "b")
@@ -46,7 +49,6 @@ defmodule BDS.TOCTOU.FileSystemTest do
assert {:ok, "FROM A"} = TemplateFileSystem.try_read(fs, "shared") assert {:ok, "FROM A"} = TemplateFileSystem.try_read(fs, "shared")
end end
@tag :tmp_dir
test "file deleted between candidate_paths and try_read does not crash", %{tmp_dir: tmp_dir} do test "file deleted between candidate_paths and try_read does not crash", %{tmp_dir: tmp_dir} do
path = Path.join(tmp_dir, "ephemeral.liquid") path = Path.join(tmp_dir, "ephemeral.liquid")
File.write!(path, "TEMPORARY") File.write!(path, "TEMPORARY")
@@ -60,7 +62,6 @@ defmodule BDS.TOCTOU.FileSystemTest do
end end
describe "read_template_file/2 protocol uses atomic read" do describe "read_template_file/2 protocol uses atomic read" do
@tag :tmp_dir
test "reads existing template", %{tmp_dir: tmp_dir} do test "reads existing template", %{tmp_dir: tmp_dir} do
File.write!(Path.join(tmp_dir, "footer.liquid"), "FOOTER") File.write!(Path.join(tmp_dir, "footer.liquid"), "FOOTER")
fs = TemplateFileSystem.new(tmp_dir) fs = TemplateFileSystem.new(tmp_dir)
@@ -68,7 +69,6 @@ defmodule BDS.TOCTOU.FileSystemTest do
assert "FOOTER" = Liquex.FileSystem.read_template_file(fs, "footer") assert "FOOTER" = Liquex.FileSystem.read_template_file(fs, "footer")
end end
@tag :tmp_dir
test "raises on missing template", %{tmp_dir: tmp_dir} do test "raises on missing template", %{tmp_dir: tmp_dir} do
fs = TemplateFileSystem.new(tmp_dir) fs = TemplateFileSystem.new(tmp_dir)