chore: section 12 closed, had to do with map and atoms

2026-05-01 17:37:08 +02:00
parent eb358bf512
commit c12001307f
18 changed files with 1025 additions and 386 deletions
--- a/lib/bds/desktop/shell_live/cli_sync.ex
+++ b/lib/bds/desktop/shell_live/cli_sync.ex
@@ -4,6 +4,7 @@ defmodule BDS.Desktop.ShellLive.CliSync do
  import Phoenix.Component, only: [assign: 3]

  alias BDS.{Media, Posts}
+  alias BDS.MapUtils
  alias BDS.Media.Media, as: MediaRecord
  alias BDS.Posts.Post
  alias BDS.UI.Workbench
@@ -12,17 +13,18 @@ defmodule BDS.Desktop.ShellLive.CliSync do
  Apply a CLI entity change payload to the shell socket. `reload_fun` is
  called with `(socket, workbench)` to refresh derived data.
  """
-  @spec apply_entity_change(Phoenix.LiveView.Socket.t(), map(),
-          (Phoenix.LiveView.Socket.t(), map() -> Phoenix.LiveView.Socket.t())) ::
+  @spec apply_entity_change(Phoenix.LiveView.Socket.t(), map(), (Phoenix.LiveView.Socket.t(),
+                                                                 map() ->
+                                                                   Phoenix.LiveView.Socket.t())) ::
          Phoenix.LiveView.Socket.t()
  def apply_entity_change(socket, payload, reload_fun) do
-    entity = Map.get(payload, :entity) || Map.get(payload, "entity") || Map.get(payload, :entity_type) || Map.get(payload, "entity_type")
+    entity = MapUtils.attr(payload, :entity) || MapUtils.attr(payload, :entity_type)

    entity_id =
-      Map.get(payload, :entity_id) || Map.get(payload, "entity_id") || Map.get(payload, :entityId) ||
+      MapUtils.attr(payload, :entity_id) || Map.get(payload, :entityId) ||
        Map.get(payload, "entityId")

-    action = normalize_action(Map.get(payload, :action) || Map.get(payload, "action"))
+    action = normalize_action(MapUtils.attr(payload, :action))

    if is_binary(entity) and entity != "" and is_binary(entity_id) and entity_id != "" and
         action in [:created, :updated, :deleted] do
@@ -45,13 +47,28 @@ defmodule BDS.Desktop.ShellLive.CliSync do
      |> assign(:shell_overlay, nil)
      |> assign(:tab_meta, Map.delete(socket.assigns.tab_meta, {:post, post_id}))
      |> assign(:post_editor_drafts, Map.delete(socket.assigns.post_editor_drafts, post_id))
-      |> assign(:post_editor_active_languages, Map.delete(socket.assigns.post_editor_active_languages, post_id))
-      |> assign(:post_editor_tag_queries, Map.delete(socket.assigns.post_editor_tag_queries, post_id))
-      |> assign(:post_editor_category_queries, Map.delete(socket.assigns.post_editor_category_queries, post_id))
-      |> assign(:post_editor_quick_actions_open, Map.delete(socket.assigns.post_editor_quick_actions_open, post_id))
+      |> assign(
+        :post_editor_active_languages,
+        Map.delete(socket.assigns.post_editor_active_languages, post_id)
+      )
+      |> assign(
+        :post_editor_tag_queries,
+        Map.delete(socket.assigns.post_editor_tag_queries, post_id)
+      )
+      |> assign(
+        :post_editor_category_queries,
+        Map.delete(socket.assigns.post_editor_category_queries, post_id)
+      )
+      |> assign(
+        :post_editor_quick_actions_open,
+        Map.delete(socket.assigns.post_editor_quick_actions_open, post_id)
+      )
      |> assign(:post_editor_modes, Map.delete(socket.assigns.post_editor_modes, post_id))
      |> assign(:post_editor_expanded, Map.delete(socket.assigns.post_editor_expanded, post_id))
-      |> assign(:post_editor_save_states, Map.delete(socket.assigns.post_editor_save_states, post_id))
+      |> assign(
+        :post_editor_save_states,
+        Map.delete(socket.assigns.post_editor_save_states, post_id)
+      )

    {socket, workbench}
  end
@@ -65,31 +82,58 @@ defmodule BDS.Desktop.ShellLive.CliSync do
      |> assign(:shell_overlay, nil)
      |> assign(:tab_meta, Map.delete(socket.assigns.tab_meta, {:media, media_id}))
      |> assign(:media_editor_drafts, Map.delete(socket.assigns.media_editor_drafts, media_id))
-      |> assign(:media_editor_quick_actions_open, Map.delete(socket.assigns.media_editor_quick_actions_open, media_id))
-      |> assign(:media_editor_post_pickers_open, Map.delete(socket.assigns.media_editor_post_pickers_open, media_id))
-      |> assign(:media_editor_post_picker_queries, Map.delete(socket.assigns.media_editor_post_picker_queries, media_id))
-      |> assign(:media_editor_save_states, Map.delete(socket.assigns.media_editor_save_states, media_id))
-      |> assign(:media_editor_translation_forms, Map.delete(socket.assigns.media_editor_translation_forms, media_id))
+      |> assign(
+        :media_editor_quick_actions_open,
+        Map.delete(socket.assigns.media_editor_quick_actions_open, media_id)
+      )
+      |> assign(
+        :media_editor_post_pickers_open,
+        Map.delete(socket.assigns.media_editor_post_pickers_open, media_id)
+      )
+      |> assign(
+        :media_editor_post_picker_queries,
+        Map.delete(socket.assigns.media_editor_post_picker_queries, media_id)
+      )
+      |> assign(
+        :media_editor_save_states,
+        Map.delete(socket.assigns.media_editor_save_states, media_id)
+      )
+      |> assign(
+        :media_editor_translation_forms,
+        Map.delete(socket.assigns.media_editor_translation_forms, media_id)
+      )

    {socket, workbench}
  end

-  defp maybe_close_deleted_tab(socket, _entity, _entity_id, _action), do: {socket, socket.assigns.workbench}
+  defp maybe_close_deleted_tab(socket, _entity, _entity_id, _action),
+    do: {socket, socket.assigns.workbench}

-  defp maybe_refresh_tab_meta(socket, "post", post_id, action) when action in [:created, :updated] do
+  defp maybe_refresh_tab_meta(socket, "post", post_id, action)
+       when action in [:created, :updated] do
    maybe_put_tab_meta(socket, :post, post_id, fn ->
      case Posts.get_post(post_id) do
-        %Post{} = post -> %{title: post.title || post.slug || post.id, subtitle: Atom.to_string(post.status)}
-        _other -> nil
+        %Post{} = post ->
+          %{title: post.title || post.slug || post.id, subtitle: Atom.to_string(post.status)}
+
+        _other ->
+          nil
      end
    end)
  end

-  defp maybe_refresh_tab_meta(socket, "media", media_id, action) when action in [:created, :updated] do
+  defp maybe_refresh_tab_meta(socket, "media", media_id, action)
+       when action in [:created, :updated] do
    maybe_put_tab_meta(socket, :media, media_id, fn ->
      case Media.get_media(media_id) do
-        %MediaRecord{} = media -> %{title: media.title || media.filename || media.id, subtitle: media.filename || media.mime_type || "media"}
-        _other -> nil
+        %MediaRecord{} = media ->
+          %{
+            title: media.title || media.filename || media.id,
+            subtitle: media.filename || media.mime_type || "media"
+          }
+
+        _other ->
+          nil
      end
    end)
  end
@@ -102,7 +146,9 @@ defmodule BDS.Desktop.ShellLive.CliSync do
    if tab_present?(socket.assigns.workbench, key) or Map.has_key?(socket.assigns.tab_meta, key) do
      case meta_fun.() do
        %{} = fresh_meta ->
-          updated_meta = Map.update(socket.assigns.tab_meta, key, fresh_meta, &Map.merge(&1, fresh_meta))
+          updated_meta =
+            Map.update(socket.assigns.tab_meta, key, fresh_meta, &Map.merge(&1, fresh_meta))
+
          assign(socket, :tab_meta, updated_meta)

        _other ->