feat: compact window on macos

test/bds/desktop/shell_live_test.exs

@@ -112,13 +112,24 @@ defmodule BDS.Desktop.ShellLiveTest do
     assert html =~ ~s(class="tab-bar-empty")
   end
 
-  test "titlebar menu stays hidden on macos because the native menu owns it" do
+  test "macos hides the custom titlebar and moves shell toggles into the status bar" do
     {:ok, view, html} = live_isolated(build_conn(), BDS.Desktop.ShellLive)
 
-    assert html =~ ~s(class="window-titlebar is-mac")
+    refute html =~ ~s(data-testid="window-titlebar")
     refute html =~ ~s(data-testid="window-titlebar-menu-bar")
     refute html =~ ~s(data-testid="window-titlebar-menu-button")
     refute html =~ ~s(data-testid="window-titlebar-menu-dropdown")
+    assert html =~ ~s(data-testid="status-shell-controls")
+    assert html =~ ~s(data-testid="toggle-sidebar")
+    assert html =~ ~s(data-testid="toggle-panel")
+    assert html =~ ~s(data-testid="toggle-assistant")
+
+    html =
+      view
+      |> element("[data-testid='toggle-sidebar']")
+      |> render_click()
+
+    assert html =~ ~s(class="sidebar-shell is-hidden")
 
     html =
       render_hook(view, "native_menu_action", %{"action" => "edit_preferences"})

test/bds/desktop_test.exs

@@ -101,9 +101,12 @@ defmodule BDS.DesktopTest do
 
     assert conn.status == 200
     assert conn.resp_body =~ ~s(class="app")
-    assert conn.resp_body =~ ~s(data-testid="window-titlebar")
-    assert conn.resp_body =~ ~s(class="window-titlebar is-mac")
+    refute conn.resp_body =~ ~s(data-testid="window-titlebar")
     refute conn.resp_body =~ ~s(data-testid="window-titlebar-menu-bar")
+    assert conn.resp_body =~ ~s(data-testid="status-shell-controls")
+    assert conn.resp_body =~ ~s(data-testid="toggle-sidebar")
+    assert conn.resp_body =~ ~s(data-testid="toggle-panel")
+    assert conn.resp_body =~ ~s(data-testid="toggle-assistant")
     assert conn.resp_body =~ ~s(class="activity-bar")
     assert conn.resp_body =~ ~s(class="sidebar")
     assert conn.resp_body =~ ~s(class="status-bar")

test/bds/ui/shell_test.exs

@@ -121,6 +121,8 @@ defmodule BDS.UI.ShellTest do
     assert css =~ ".window-titlebar-menu-bar.is-hidden"
     assert css =~ "--vscode-statusBar-background: #007acc"
     assert css =~ ".status-bar-left,"
+    assert css =~ ".status-shell-controls"
+    assert css =~ ".status-shell-toggle-button"
     assert css =~ "gap: 4px"
     assert css =~ "padding: 0 8px"
     assert css =~ "height: 100%"
@@ -156,6 +158,7 @@ defmodule BDS.UI.ShellTest do
     assert live_js =~ "event.preventDefault()"
     assert live_js =~ "this.pushEvent(\"shortcut\""
     assert template =~ "data-shortcuts={encoded_shortcuts(@client_shortcuts)}"
+    assert template =~ "data-testid=\"status-shell-controls\""
     assert template =~ "activity-bar-badge"
     assert template =~ "tab-actions"
     assert template =~ "tab-dirty-indicator"