Address code review: add error logging, fix type cast, improve error messages

Co-authored-by: rfc1437 <774975+rfc1437@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-26 21:57:16 +00:00
parent 2aa23f2dd1
commit fda97c0977
3 changed files with 9 additions and 6 deletions

View File

@@ -859,7 +859,8 @@ export async function replaceAllMacrosAsync(
if (hasUnknownMacros && pythonMacroRenderer) {
try {
pythonScripts = await pythonMacroRenderer.getEnabledMacroScripts();
} catch {
} catch (error) {
console.warn('[PageRenderer] Failed to resolve Python macro scripts:', error instanceof Error ? error.message : String(error));
pythonScripts = [];
}
}
@@ -892,7 +893,7 @@ export async function replaceAllMacrosAsync(
hook: m.name,
source: { kind: 'macro', id: pythonScript.id },
},
params: params as Record<string, unknown>,
params: params,
};
const result = await pythonMacroRenderer.renderMacro({
@@ -904,7 +905,8 @@ export async function replaceAllMacrosAsync(
});
rendered.push(result.html);
} catch {
} catch (error) {
console.warn(`[PageRenderer] Python macro '${m.name}' failed:`, error instanceof Error ? error.message : String(error));
rendered.push('');
}
} else {