feat: sitemap validation second part

2026-02-21 15:57:26 +01:00
parent bca3da1587
commit cdf064b6a1
4 changed files with 192 additions and 19 deletions
--- a/tests/engine/BlogGenerationEngine.test.ts
+++ b/tests/engine/BlogGenerationEngine.test.ts
@@ -607,6 +607,64 @@ describe('BlogGenerationEngine', () => {
    expect(sitemap).toContain('<loc>https://example.com/page/2/</loc>');
  });

+  it('applies validation by deleting first, then rendering category, tag, and date sections', async () => {
+    const posts = [
+      makePost({ id: '1', slug: 'ordered-post', categories: ['news'], tags: ['ordered-tag'], createdAt: new Date('2025-01-15T10:00:00Z') }),
+    ];
+    setupPosts(posts);
+
+    await mkdir(path.join(tempDir, 'html', 'stale'), { recursive: true });
+    await writeFile(path.join(tempDir, 'html', 'stale', 'index.html'), '<html>stale</html>', 'utf-8');
+
+    const { BlogGenerationEngine } = await import('../../src/main/engine/BlogGenerationEngine');
+    const engine = new BlogGenerationEngine();
+
+    const callOrder: string[] = [];
+    const generateSpy = vi.spyOn(engine, 'generate').mockImplementation(async (opts) => {
+      const staleExistsAtRenderTime = await fileExists(path.join(tempDir, 'html', 'stale', 'index.html'));
+      expect(staleExistsAtRenderTime).toBe(false);
+      callOrder.push((opts.sections || []).join(','));
+      return {
+        path: path.join(tempDir, 'html', 'sitemap.xml'),
+        urlCount: 0,
+        postCount: 0,
+        feedPostCount: 0,
+        tagCount: 0,
+        categoryCount: 0,
+        archiveCount: 0,
+        pagesGenerated: 1,
+        feeds: {
+          rssPath: path.join(tempDir, 'html', 'rss.xml'),
+          atomPath: path.join(tempDir, 'html', 'atom.xml'),
+        },
+        changed: {
+          sitemap: false,
+          rss: false,
+          atom: false,
+        },
+      };
+    });
+
+    const result = await engine.applyValidation({
+      projectId: 'test',
+      projectName: 'Test Blog',
+      dataDir: tempDir,
+      baseUrl: 'https://example.com',
+    }, {
+      sitemapPath: path.join(tempDir, 'html', 'sitemap.xml'),
+      sitemapChanged: false,
+      missingUrlPaths: ['/category/news', '/tag/ordered-tag', '/2025/01'],
+      extraUrlPaths: ['/stale'],
+      expectedUrlCount: 3,
+      existingHtmlUrlCount: 1,
+    }, vi.fn());
+
+    expect(result.deletedUrlCount).toBe(1);
+    expect(callOrder).toEqual(['category', 'tag', 'date']);
+
+    generateSpy.mockRestore();
+  });
+
  it('generates HTML that references local assets not CDN', async () => {
    const posts = [makePost({ id: '1', slug: 'test' })];
    await generate(posts);
--- a/tests/ipc/handlers.test.ts
+++ b/tests/ipc/handlers.test.ts
@@ -2303,6 +2303,77 @@ describe('IPC Handlers', () => {
          'utf-8',
        );
      });
+
+      it('should run validation via taskManager.runTask', async () => {
+        const mockProject = createMockProject({ id: 'test-project', dataPath: '/mock/data' });
+        mockProjectEngine.getActiveProject.mockResolvedValue(mockProject);
+        mockProjectEngine.getDataDir.mockReturnValue('/mock/data/dir');
+        mockMetaEngine.getProjectMetadata.mockResolvedValue({
+          name: 'Test Project',
+          publicUrl: 'https://blog.example.com',
+        });
+
+        mockPostEngine.getPostsFiltered.mockResolvedValue([]);
+        mockPostEngine.getPublishedVersion.mockResolvedValue(null);
+
+        const { mkdir, writeFile, readdir } = await import('fs/promises');
+        vi.mocked(mkdir).mockResolvedValue(undefined);
+        vi.mocked(writeFile).mockResolvedValue(undefined);
+        vi.mocked(readdir).mockResolvedValue([] as never);
+
+        mockTaskManager.runTask.mockImplementation(async (task: any) => {
+          return task.execute(vi.fn());
+        });
+
+        await invokeHandler('blog:validateSite');
+
+        expect(mockTaskManager.runTask).toHaveBeenCalledWith(
+          expect.objectContaining({
+            name: 'Validate Site',
+            execute: expect.any(Function),
+          }),
+        );
+      });
+    });
+
+    describe('blog:applyValidation', () => {
+      it('should run apply via taskManager.runTask', async () => {
+        const mockProject = createMockProject({ id: 'test-project', dataPath: '/mock/data' });
+        mockProjectEngine.getActiveProject.mockResolvedValue(mockProject);
+        mockProjectEngine.getDataDir.mockReturnValue('/mock/data/dir');
+        mockMetaEngine.getProjectMetadata.mockResolvedValue({
+          name: 'Test Project',
+          publicUrl: 'https://blog.example.com',
+        });
+
+        mockPostEngine.getPostsFiltered.mockResolvedValue([]);
+        mockPostEngine.getPublishedVersion.mockResolvedValue(null);
+
+        const { mkdir, writeFile, readdir } = await import('fs/promises');
+        vi.mocked(mkdir).mockResolvedValue(undefined);
+        vi.mocked(writeFile).mockResolvedValue(undefined);
+        vi.mocked(readdir).mockResolvedValue([] as never);
+
+        mockTaskManager.runTask.mockImplementation(async (task: any) => {
+          return task.execute(vi.fn());
+        });
+
+        await invokeHandler('blog:applyValidation', {
+          sitemapPath: '/mock/data/dir/html/sitemap.xml',
+          sitemapChanged: false,
+          missingUrlPaths: ['/category/news'],
+          extraUrlPaths: ['/stale'],
+          expectedUrlCount: 1,
+          existingHtmlUrlCount: 1,
+        });
+
+        expect(mockTaskManager.runTask).toHaveBeenCalledWith(
+          expect.objectContaining({
+            name: 'Apply Site Validation',
+            execute: expect.any(Function),
+          }),
+        );
+      });
    });
  });