Feature/post media translations (#42)
* chore: updated todo with translation ideas * feat: first take at the implementation of translations * fix: small addition for the translation feature * feat: support language switching in the editor and preview * feat: better handling of long bodies by not running them through a json envelope * fix: unknown macros have better fallback * feat: api for python to get translations * fix: strip dumb prefix of content in translation * feat: extend meta diff for translations * feat: hook up translations to rebuild-from-disk * feat: generation of the website prefers project language, falling back to canonical language * fix: crashes during rendering * feat: translation validation report * fix: made the translation validation actually work * chore: reorganization of menu * fix: some topics cleanup * chore: updated doc * feat: translations for media * feat: more aligned in UI/UX * feat: edit translations possible * chore: added full multi-language todo * chore: updated todo for clarity * feat: implementation of full multi-linguality * fix: page creation creates pages * fix: flags on every page * fix: better prompt * feat: made MCP server aware of language content * feat: python tools for translations * fix: better fill-in-translations * fix: better prompt for translation. maybe. * fix: losing posts from search due to translation process * fix: translation validation handles in-db content and fill-in of missing translations fixed to flush * fix: faster scanning for infilling of missing translations * chore: updated agent instructions * feat: calendar and tag cloud respect current language now * fix: retries going up * fix: got metadata-diff and rebuild into sync * fix: extended meta-diff for timestamps * fix: made website validation look at translated content, too * fix: multi-lingual search * chore: refactor Editor.tsx into two separate editors * feat: do language detection when no explicit language given --------- Co-authored-by: hugo <hugoms@me.com>
This commit is contained in:
Georg Bauer
@@ -43,6 +43,7 @@ function createMockDeps() {
|
||||
|
||||
const postEngine = {
|
||||
getPost: vi.fn(),
|
||||
upsertPostTranslation: vi.fn(),
|
||||
} as any;
|
||||
|
||||
return { chatEngine, providers, mediaEngine, postEngine };
|
||||
@@ -182,3 +183,283 @@ describe('OneShotTasks.analyzePost', () => {
|
||||
expect(deps.providers.resolveModel).toHaveBeenCalledWith('custom-model-id');
|
||||
});
|
||||
});
|
||||
|
||||
describe('OneShotTasks.translatePost', () => {
|
||||
let deps: ReturnType<typeof createMockDeps>;
|
||||
let tasks: OneShotTasks;
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
deps = createMockDeps();
|
||||
tasks = new OneShotTasks(deps.providers, deps.chatEngine, deps.mediaEngine, deps.postEngine);
|
||||
});
|
||||
|
||||
it('instructs the AI to leave fenced code blocks untranslated', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Intro\n\n```ts\nconst label = "Hello";\n```',
|
||||
language: 'en',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Resume',
|
||||
content: 'Intro\n\n```ts\nconst label = "Hello";\n```',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: '{"title":"Mon Post","excerpt":"Resume"}',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: 'Intro\n\n```ts\nconst label = "Hello";\n```',
|
||||
} as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(mockGenerateText).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
system: expect.stringContaining('Leave text inside fenced code blocks untranslated.'),
|
||||
}));
|
||||
});
|
||||
|
||||
it('translates markdown body outside a JSON envelope', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Intro\n\n```ts\nconst config = { hello: "world" };\n```\n\nEnd.',
|
||||
language: 'en',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Resume',
|
||||
content: 'Bonjour',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: '{"title":"Mon Post","excerpt":"Resume"}',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: 'Introduction\n\n```ts\nconst config = { hello: "world" };\n```\n\nFin.',
|
||||
} as any);
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(2);
|
||||
expect(mockGenerateText).toHaveBeenNthCalledWith(1, expect.objectContaining({
|
||||
system: expect.stringContaining('keys title and excerpt'),
|
||||
}));
|
||||
expect(mockGenerateText).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
system: expect.stringContaining('Return ONLY the translated Markdown body'),
|
||||
}));
|
||||
expect(deps.postEngine.upsertPostTranslation).toHaveBeenCalledWith('post-1', 'fr', {
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Resume',
|
||||
content: 'Introduction\n\n```ts\nconst config = { hello: "world" };\n```\n\nFin.',
|
||||
});
|
||||
});
|
||||
|
||||
it('passes the raw markdown body without a leading content label', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: '# Heading\n\nBody text',
|
||||
language: 'en',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Resume',
|
||||
content: '# Titre\n\nTexte',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: '{"title":"Mon Post","excerpt":"Resume"}',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: '# Titre\n\nTexte',
|
||||
} as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(mockGenerateText).toHaveBeenNthCalledWith(2, expect.objectContaining({
|
||||
prompt: '# Heading\n\nBody text',
|
||||
}));
|
||||
});
|
||||
|
||||
it('strips an accidental leading content label from translated markdown', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'Mein Beitrag',
|
||||
excerpt: 'Zusammenfassung',
|
||||
content: '# Uberschrift\n\nText',
|
||||
language: 'de',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'en',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: '# Heading\n\nText',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: '{"title":"My Post","excerpt":"Summary"}',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: 'content:\n\n# Heading\n\nText',
|
||||
} as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'en');
|
||||
|
||||
expect(deps.postEngine.upsertPostTranslation).toHaveBeenCalledWith('post-1', 'en', {
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: '# Heading\n\nText',
|
||||
});
|
||||
});
|
||||
|
||||
it('instructs the AI to translate only — never invent or add content', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: '# Hello\n\nWorld',
|
||||
language: 'en',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Resume',
|
||||
content: '# Bonjour\n\nMonde',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"title":"Mon Post","excerpt":"Resume"}' } as any)
|
||||
.mockResolvedValueOnce({ text: '# Bonjour\n\nMonde' } as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
const contentSystemPrompt = mockGenerateText.mock.calls[1][0].system as string;
|
||||
expect(contentSystemPrompt).toMatch(/do not invent|do not add|only translate/i);
|
||||
expect(contentSystemPrompt).toMatch(/macro|shortcode|non-translatable/i);
|
||||
});
|
||||
|
||||
it('instructs the AI to keep markdown link text unchanged and translate surrounding prose', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'USearch Library',
|
||||
excerpt: '',
|
||||
content: '[unum-cloud/USearch: Fast Search](https://github.com/unum-cloud/USearch) - drin was drauf steht. Eine Library.',
|
||||
language: 'de',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'en',
|
||||
title: 'USearch Library',
|
||||
excerpt: '',
|
||||
content: '[unum-cloud/USearch: Fast Search](https://github.com/unum-cloud/USearch) - what it says on the tin. A library.',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"title":"USearch Library","excerpt":""}' } as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: '[unum-cloud/USearch: Fast Search](https://github.com/unum-cloud/USearch) - what it says on the tin. A library.',
|
||||
} as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'en');
|
||||
|
||||
const contentSystemPrompt = mockGenerateText.mock.calls[1][0].system as string;
|
||||
expect(contentSystemPrompt).toMatch(/link text/i);
|
||||
expect(contentSystemPrompt).toMatch(/url/i);
|
||||
});
|
||||
|
||||
it('falls back to source title and excerpt when metadata JSON is invalid', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Intro',
|
||||
language: 'en',
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Bonjour',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: 'not valid json',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: 'Bonjour',
|
||||
} as any);
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(deps.postEngine.upsertPostTranslation).toHaveBeenCalledWith('post-1', 'fr', {
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Bonjour',
|
||||
});
|
||||
});
|
||||
|
||||
it('passes status published when autoPublish is set', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Hello world',
|
||||
language: 'en',
|
||||
status: 'published',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Résumé',
|
||||
content: 'Bonjour le monde',
|
||||
});
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({
|
||||
text: '{"title":"Mon Post","excerpt":"Résumé"}',
|
||||
} as any)
|
||||
.mockResolvedValueOnce({
|
||||
text: 'Bonjour le monde',
|
||||
} as any);
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'fr', { autoPublish: true });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(deps.postEngine.upsertPostTranslation).toHaveBeenCalledWith('post-1', 'fr', {
|
||||
title: 'Mon Post',
|
||||
excerpt: 'Résumé',
|
||||
content: 'Bonjour le monde',
|
||||
status: 'published',
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
386
tests/engine/ai/languageDetectionBeforeTranslation.test.ts
Normal file
386
tests/engine/ai/languageDetectionBeforeTranslation.test.ts
Normal file
@@ -0,0 +1,386 @@
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
||||
|
||||
// Mock the AI SDK generateText before importing OneShotTasks
|
||||
vi.mock('ai', () => ({
|
||||
generateText: vi.fn(),
|
||||
}));
|
||||
|
||||
// Mock i18n
|
||||
vi.mock('../../../src/main/shared/i18n', () => ({
|
||||
resolveSupportedRenderLanguage: vi.fn((lang: string) => lang),
|
||||
translateRender: vi.fn((_lang: string, key: string) => key),
|
||||
}));
|
||||
|
||||
import { OneShotTasks } from '../../../src/main/engine/ai/tasks';
|
||||
import { generateText } from 'ai';
|
||||
|
||||
const mockGenerateText = vi.mocked(generateText);
|
||||
|
||||
function createMockDeps() {
|
||||
const chatEngine = {
|
||||
getSetting: vi.fn().mockResolvedValue(null),
|
||||
} as any;
|
||||
|
||||
const providers = {
|
||||
detectModelProvider: vi.fn().mockReturnValue('opencode'),
|
||||
isProviderKeySet: vi.fn().mockReturnValue(true),
|
||||
getOpencodeKey: vi.fn().mockReturnValue('test-key'),
|
||||
getMistralKey: vi.fn().mockReturnValue(null),
|
||||
resolveModel: vi.fn().mockReturnValue('mock-model'),
|
||||
isOfflineMode: vi.fn().mockReturnValue(false),
|
||||
isOllamaModel: vi.fn().mockReturnValue(false),
|
||||
isLmstudioModel: vi.fn().mockReturnValue(false),
|
||||
getFirstKnownLocalModelId: vi.fn().mockReturnValue(null),
|
||||
} as any;
|
||||
|
||||
const mediaEngine = {
|
||||
getMedia: vi.fn(),
|
||||
updateMedia: vi.fn(),
|
||||
upsertMediaTranslation: vi.fn(),
|
||||
} as any;
|
||||
|
||||
const postEngine = {
|
||||
getPost: vi.fn(),
|
||||
updatePost: vi.fn(),
|
||||
upsertPostTranslation: vi.fn(),
|
||||
} as any;
|
||||
|
||||
return { chatEngine, providers, mediaEngine, postEngine };
|
||||
}
|
||||
|
||||
describe('translatePost: auto-detect language when not set', () => {
|
||||
let deps: ReturnType<typeof createMockDeps>;
|
||||
let tasks: OneShotTasks;
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
deps = createMockDeps();
|
||||
tasks = new OneShotTasks(deps.providers, deps.chatEngine, deps.mediaEngine, deps.postEngine);
|
||||
});
|
||||
|
||||
it('detects and persists language before translating when post has no language', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'Mein Beitrag',
|
||||
excerpt: 'Zusammenfassung',
|
||||
content: 'Dies ist ein deutscher Blogbeitrag über verschiedene Themen.',
|
||||
language: undefined, // No language set
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.updatePost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
language: 'de',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'en',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'This is a German blog post about various topics.',
|
||||
});
|
||||
|
||||
// First call: language detection response
|
||||
// Then: metadata translation response
|
||||
// Then: content translation response
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "de"}' } as any) // language detection
|
||||
.mockResolvedValueOnce({ text: '{"title":"My Post","excerpt":"Summary"}' } as any) // metadata translation
|
||||
.mockResolvedValueOnce({ text: 'This is a German blog post about various topics.' } as any); // content translation
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'en');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
// Language detection should have been called (first generateText call)
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(3);
|
||||
// Language should have been persisted
|
||||
expect(deps.postEngine.updatePost).toHaveBeenCalledWith('post-1', { language: 'de' });
|
||||
// Translation prompts should use detected language 'de', not fallback 'en'
|
||||
const metadataCall = mockGenerateText.mock.calls[1][0];
|
||||
expect((metadataCall as any).system).toContain('de');
|
||||
});
|
||||
|
||||
it('skips detection when post has explicit language set', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'This is an English blog post.',
|
||||
language: 'en', // Explicitly set
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Article',
|
||||
excerpt: 'Résumé',
|
||||
content: 'Ceci est un article de blog en anglais.',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"title":"Mon Article","excerpt":"Résumé"}' } as any) // metadata translation
|
||||
.mockResolvedValueOnce({ text: 'Ceci est un article de blog en anglais.' } as any); // content translation
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
// Only 2 calls: metadata + content translation, NO language detection
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(2);
|
||||
// updatePost should NOT have been called for language
|
||||
expect(deps.postEngine.updatePost).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('proceeds with fallback when language detection fails', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'My Post',
|
||||
excerpt: 'Summary',
|
||||
content: 'Some content here.',
|
||||
language: undefined,
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'fr',
|
||||
title: 'Mon Article',
|
||||
excerpt: 'Résumé',
|
||||
content: 'Du contenu ici.',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: 'garbage response' } as any) // language detection fails
|
||||
.mockResolvedValueOnce({ text: '{"title":"Mon Article","excerpt":"Résumé"}' } as any)
|
||||
.mockResolvedValueOnce({ text: 'Du contenu ici.' } as any);
|
||||
|
||||
const result = await tasks.translatePost('post-1', 'fr');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
// updatePost should NOT have been called since detection failed
|
||||
expect(deps.postEngine.updatePost).not.toHaveBeenCalled();
|
||||
// Should still proceed with translation (3 calls total: detection + 2 translation)
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(3);
|
||||
});
|
||||
|
||||
it('uses detected language in translation prompts', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'Mon Article',
|
||||
excerpt: '',
|
||||
content: 'Ceci est un article français.',
|
||||
language: undefined,
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.updatePost.mockResolvedValue({ id: 'post-1', language: 'fr' });
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'en',
|
||||
title: 'My Article',
|
||||
excerpt: '',
|
||||
content: 'This is a French article.',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "fr"}' } as any)
|
||||
.mockResolvedValueOnce({ text: '{"title":"My Article","excerpt":""}' } as any)
|
||||
.mockResolvedValueOnce({ text: 'This is a French article.' } as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'en');
|
||||
|
||||
// The translation prompt should use 'fr' as source language
|
||||
const metadataSystemPrompt = mockGenerateText.mock.calls[1][0].system as string;
|
||||
const contentSystemPrompt = mockGenerateText.mock.calls[2][0].system as string;
|
||||
expect(metadataSystemPrompt).toContain('from fr to en');
|
||||
expect(contentSystemPrompt).toContain('from fr to en');
|
||||
});
|
||||
|
||||
it('treats null language the same as undefined (no language)', async () => {
|
||||
deps.postEngine.getPost.mockResolvedValue({
|
||||
id: 'post-1',
|
||||
title: 'Test Post',
|
||||
excerpt: '',
|
||||
content: 'Some content.',
|
||||
language: null, // null, not undefined
|
||||
status: 'draft',
|
||||
});
|
||||
deps.postEngine.updatePost.mockResolvedValue({ id: 'post-1', language: 'en' });
|
||||
deps.postEngine.upsertPostTranslation.mockResolvedValue({
|
||||
id: 'translation-1',
|
||||
translationFor: 'post-1',
|
||||
language: 'de',
|
||||
title: 'Test',
|
||||
excerpt: '',
|
||||
content: 'Inhalt.',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "en"}' } as any)
|
||||
.mockResolvedValueOnce({ text: '{"title":"Test","excerpt":""}' } as any)
|
||||
.mockResolvedValueOnce({ text: 'Inhalt.' } as any);
|
||||
|
||||
await tasks.translatePost('post-1', 'de');
|
||||
|
||||
// Should have called detection since language is null
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(3);
|
||||
expect(deps.postEngine.updatePost).toHaveBeenCalledWith('post-1', { language: 'en' });
|
||||
});
|
||||
});
|
||||
|
||||
describe('translateMediaMetadata: auto-detect language when not set', () => {
|
||||
let deps: ReturnType<typeof createMockDeps>;
|
||||
let tasks: OneShotTasks;
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
deps = createMockDeps();
|
||||
tasks = new OneShotTasks(deps.providers, deps.chatEngine, deps.mediaEngine, deps.postEngine);
|
||||
});
|
||||
|
||||
it('detects and persists language before translating when media has no language', async () => {
|
||||
deps.mediaEngine.getMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
title: 'Sonnenuntergang am Meer',
|
||||
alt: 'Ein wunderschöner Sonnenuntergang',
|
||||
caption: 'Aufgenommen im Sommer',
|
||||
language: undefined,
|
||||
});
|
||||
deps.mediaEngine.updateMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
language: 'de',
|
||||
});
|
||||
deps.mediaEngine.upsertMediaTranslation.mockResolvedValue({
|
||||
id: 'mt-1',
|
||||
translationFor: 'media-1',
|
||||
language: 'en',
|
||||
title: 'Sunset at Sea',
|
||||
alt: 'A beautiful sunset',
|
||||
caption: 'Taken in summer',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "de"}' } as any) // language detection
|
||||
.mockResolvedValueOnce({ text: '{"title":"Sunset at Sea","alt":"A beautiful sunset","caption":"Taken in summer"}' } as any); // translation
|
||||
|
||||
const result = await tasks.translateMediaMetadata('media-1', 'en');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(2);
|
||||
expect(deps.mediaEngine.updateMedia).toHaveBeenCalledWith('media-1', { language: 'de' });
|
||||
// Translation prompt should use detected language 'de'
|
||||
const translationCall = mockGenerateText.mock.calls[1][0];
|
||||
expect((translationCall as any).system).toContain('de');
|
||||
});
|
||||
|
||||
it('skips detection when media has explicit language set', async () => {
|
||||
deps.mediaEngine.getMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
title: 'Sunset at Sea',
|
||||
alt: 'A beautiful sunset',
|
||||
caption: 'Taken in summer',
|
||||
language: 'en',
|
||||
});
|
||||
deps.mediaEngine.upsertMediaTranslation.mockResolvedValue({
|
||||
id: 'mt-1',
|
||||
translationFor: 'media-1',
|
||||
language: 'de',
|
||||
title: 'Sonnenuntergang',
|
||||
alt: 'Schön',
|
||||
caption: 'Im Sommer',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"title":"Sonnenuntergang","alt":"Schön","caption":"Im Sommer"}' } as any);
|
||||
|
||||
const result = await tasks.translateMediaMetadata('media-1', 'de');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(1);
|
||||
expect(deps.mediaEngine.updateMedia).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('proceeds with fallback when media language detection fails', async () => {
|
||||
deps.mediaEngine.getMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
title: 'Test Image',
|
||||
alt: 'Alt text',
|
||||
caption: 'Caption',
|
||||
language: undefined,
|
||||
});
|
||||
deps.mediaEngine.upsertMediaTranslation.mockResolvedValue({
|
||||
id: 'mt-1',
|
||||
translationFor: 'media-1',
|
||||
language: 'de',
|
||||
title: 'Testbild',
|
||||
alt: 'Alt',
|
||||
caption: 'Beschriftung',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: 'garbage' } as any) // detection fails
|
||||
.mockResolvedValueOnce({ text: '{"title":"Testbild","alt":"Alt","caption":"Beschriftung"}' } as any);
|
||||
|
||||
const result = await tasks.translateMediaMetadata('media-1', 'de');
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(deps.mediaEngine.updateMedia).not.toHaveBeenCalled();
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
|
||||
it('uses detected language in media translation prompts', async () => {
|
||||
deps.mediaEngine.getMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
title: 'Tramonto sul mare',
|
||||
alt: 'Un bel tramonto',
|
||||
caption: 'Fotografato in estate',
|
||||
language: undefined,
|
||||
});
|
||||
deps.mediaEngine.updateMedia.mockResolvedValue({ id: 'media-1', language: 'it' });
|
||||
deps.mediaEngine.upsertMediaTranslation.mockResolvedValue({
|
||||
id: 'mt-1',
|
||||
translationFor: 'media-1',
|
||||
language: 'en',
|
||||
title: 'Sunset',
|
||||
alt: 'Beautiful',
|
||||
caption: 'Summer',
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "it"}' } as any)
|
||||
.mockResolvedValueOnce({ text: '{"title":"Sunset","alt":"Beautiful","caption":"Summer"}' } as any);
|
||||
|
||||
await tasks.translateMediaMetadata('media-1', 'en');
|
||||
|
||||
const translationSystemPrompt = mockGenerateText.mock.calls[1][0].system as string;
|
||||
expect(translationSystemPrompt).toContain('from it to en');
|
||||
});
|
||||
|
||||
it('treats null language the same as undefined (no language)', async () => {
|
||||
deps.mediaEngine.getMedia.mockResolvedValue({
|
||||
id: 'media-1',
|
||||
title: 'Test',
|
||||
alt: 'Alt',
|
||||
caption: null,
|
||||
language: null,
|
||||
});
|
||||
deps.mediaEngine.updateMedia.mockResolvedValue({ id: 'media-1', language: 'en' });
|
||||
deps.mediaEngine.upsertMediaTranslation.mockResolvedValue({
|
||||
id: 'mt-1',
|
||||
translationFor: 'media-1',
|
||||
language: 'de',
|
||||
title: 'Test',
|
||||
alt: 'Alt',
|
||||
caption: null,
|
||||
});
|
||||
|
||||
mockGenerateText
|
||||
.mockResolvedValueOnce({ text: '{"language": "en"}' } as any)
|
||||
.mockResolvedValueOnce({ text: '{"title":"Test","alt":"Alt","caption":null}' } as any);
|
||||
|
||||
await tasks.translateMediaMetadata('media-1', 'de');
|
||||
|
||||
expect(mockGenerateText).toHaveBeenCalledTimes(2);
|
||||
expect(deps.mediaEngine.updateMedia).toHaveBeenCalledWith('media-1', { language: 'en' });
|
||||
});
|
||||
});
|
||||
116
tests/engine/ai/retryWithBackoff.test.ts
Normal file
116
tests/engine/ai/retryWithBackoff.test.ts
Normal file
@@ -0,0 +1,116 @@
|
||||
import { describe, expect, it, vi } from 'vitest';
|
||||
import { retryWithBackoff } from '../../../src/main/engine/ai/retry';
|
||||
|
||||
describe('retryWithBackoff', () => {
|
||||
it('returns immediately on success (no retries)', async () => {
|
||||
const fn = vi.fn(async () => ({ success: true, value: 42 }));
|
||||
|
||||
const result = await retryWithBackoff(fn);
|
||||
|
||||
expect(result).toEqual({ success: true, value: 42 });
|
||||
expect(fn).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it('retries up to maxRetries times with exponential delays on failure', async () => {
|
||||
vi.useFakeTimers();
|
||||
|
||||
const fn = vi.fn(async () => ({ success: false, error: 'rate limited' }));
|
||||
|
||||
const promise = retryWithBackoff(fn, { maxRetries: 3, baseDelayMs: 5000 });
|
||||
|
||||
// Initial call happens immediately
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
expect(fn).toHaveBeenCalledTimes(1);
|
||||
|
||||
// Retry 1 after 5s
|
||||
await vi.advanceTimersByTimeAsync(5000);
|
||||
expect(fn).toHaveBeenCalledTimes(2);
|
||||
|
||||
// Retry 2 after 10s
|
||||
await vi.advanceTimersByTimeAsync(10000);
|
||||
expect(fn).toHaveBeenCalledTimes(3);
|
||||
|
||||
// Retry 3 after 20s
|
||||
await vi.advanceTimersByTimeAsync(20000);
|
||||
expect(fn).toHaveBeenCalledTimes(4);
|
||||
|
||||
const result = await promise;
|
||||
expect(result).toEqual({ success: false, error: 'rate limited' });
|
||||
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it('stops retrying once the function succeeds', async () => {
|
||||
vi.useFakeTimers();
|
||||
|
||||
const fn = vi.fn()
|
||||
.mockResolvedValueOnce({ success: false, error: 'fail' })
|
||||
.mockResolvedValueOnce({ success: true, value: 'ok' });
|
||||
|
||||
const promise = retryWithBackoff(fn, { maxRetries: 3, baseDelayMs: 5000 });
|
||||
|
||||
// Initial call fails
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
expect(fn).toHaveBeenCalledTimes(1);
|
||||
|
||||
// Retry 1 after 5s — succeeds
|
||||
await vi.advanceTimersByTimeAsync(5000);
|
||||
expect(fn).toHaveBeenCalledTimes(2);
|
||||
|
||||
const result = await promise;
|
||||
expect(result).toEqual({ success: true, value: 'ok' });
|
||||
// Should not retry further
|
||||
expect(fn).toHaveBeenCalledTimes(2);
|
||||
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it('uses default 3 retries with 5s base delay', async () => {
|
||||
vi.useFakeTimers();
|
||||
|
||||
const fn = vi.fn(async () => ({ success: false }));
|
||||
|
||||
const promise = retryWithBackoff(fn);
|
||||
|
||||
// Initial + 3 retries = 4 total calls
|
||||
await vi.advanceTimersByTimeAsync(0); // initial
|
||||
await vi.advanceTimersByTimeAsync(5000); // retry 1 (5s)
|
||||
await vi.advanceTimersByTimeAsync(10000); // retry 2 (10s)
|
||||
await vi.advanceTimersByTimeAsync(20000); // retry 3 (20s)
|
||||
|
||||
await promise;
|
||||
expect(fn).toHaveBeenCalledTimes(4);
|
||||
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it('applies exponential doubling: 5s, 10s, 20s', async () => {
|
||||
vi.useFakeTimers();
|
||||
|
||||
const delays: number[] = [];
|
||||
const setTimeoutSpy = vi.spyOn(globalThis, 'setTimeout');
|
||||
|
||||
const fn = vi.fn(async () => ({ success: false }));
|
||||
|
||||
const promise = retryWithBackoff(fn, { maxRetries: 3, baseDelayMs: 5000 });
|
||||
|
||||
await vi.advanceTimersByTimeAsync(0);
|
||||
await vi.advanceTimersByTimeAsync(5000);
|
||||
await vi.advanceTimersByTimeAsync(10000);
|
||||
await vi.advanceTimersByTimeAsync(20000);
|
||||
|
||||
await promise;
|
||||
|
||||
// Extract the delay values passed to setTimeout for our retries
|
||||
const timeoutCalls = setTimeoutSpy.mock.calls
|
||||
.filter(([, ms]) => typeof ms === 'number' && ms >= 5000)
|
||||
.map(([, ms]) => ms);
|
||||
|
||||
expect(timeoutCalls).toContain(5000);
|
||||
expect(timeoutCalls).toContain(10000);
|
||||
expect(timeoutCalls).toContain(20000);
|
||||
|
||||
setTimeoutSpy.mockRestore();
|
||||
vi.useRealTimers();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user