wip: complete rework first round
This commit is contained in:
@@ -1,8 +1,7 @@
|
||||
import React from 'react';
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
||||
import { fireEvent, render } from '@testing-library/react';
|
||||
import { render } from '@testing-library/react';
|
||||
import { AssistantSidebar } from '../../../src/renderer/components/AssistantSidebar/AssistantSidebar';
|
||||
import { AssistantPanelControls } from '../../../src/renderer/components/AssistantPanelControls';
|
||||
import { useAppStore } from '../../../src/renderer/store';
|
||||
|
||||
describe('assistant sidebar guard rails', () => {
|
||||
@@ -14,7 +13,6 @@ describe('assistant sidebar guard rails', () => {
|
||||
validateApiKey: vi.fn(),
|
||||
setApiKey: vi.fn(),
|
||||
getApiKey: vi.fn(),
|
||||
getProtocolHealth: vi.fn(),
|
||||
getAvailableModels: vi.fn(),
|
||||
setDefaultModel: vi.fn(),
|
||||
getSystemPrompt: vi.fn(),
|
||||
@@ -36,6 +34,8 @@ describe('assistant sidebar guard rails', () => {
|
||||
onToolCall: vi.fn(() => vi.fn()),
|
||||
onToolResult: vi.fn(() => vi.fn()),
|
||||
onTitleUpdated: vi.fn(() => vi.fn()),
|
||||
onA2UIMessage: vi.fn(() => vi.fn()),
|
||||
dispatchA2UIAction: vi.fn(),
|
||||
} as never;
|
||||
});
|
||||
|
||||
@@ -44,60 +44,4 @@ describe('assistant sidebar guard rails', () => {
|
||||
|
||||
expect(useAppStore.getState().tabs.some((tab) => tab.type === 'chat')).toBe(false);
|
||||
});
|
||||
|
||||
it('renders rich assistant panel widget branches at runtime', () => {
|
||||
const onAction = vi.fn();
|
||||
|
||||
const { container } = render(
|
||||
React.createElement(AssistantPanelControls, {
|
||||
elements: [
|
||||
{ type: 'chart', chartType: 'bar', title: 'Trend', series: [{ label: 'Jan', value: 10 }] },
|
||||
{
|
||||
type: 'form',
|
||||
formId: 'f1',
|
||||
submitLabel: 'Submit',
|
||||
action: 'submitNeedsInput',
|
||||
fields: [{ key: 'name', label: 'Name', inputType: 'text', required: true }],
|
||||
},
|
||||
{ type: 'datePicker', key: 'date', label: 'Date', submitLabel: 'Pick', action: 'submitNeedsInput' },
|
||||
{ type: 'card', title: 'Card', body: 'Body', actions: [{ label: 'Open', action: 'openSettings' }] },
|
||||
{ type: 'image', src: 'https://example.com/a.png', caption: 'Image', action: 'openSettings' },
|
||||
{
|
||||
type: 'tabs',
|
||||
tabs: [{ id: 'tab-1', label: 'Tab 1', elements: [{ type: 'text', text: 'Inside tab' }] }],
|
||||
},
|
||||
{ type: 'input', key: 'query', label: 'Query', inputType: 'text', submitLabel: 'Run', action: 'openSettings' },
|
||||
],
|
||||
onAction,
|
||||
}),
|
||||
);
|
||||
|
||||
expect(container.querySelector('.assistant-panel-chart')).not.toBeNull();
|
||||
expect(container.querySelector('.assistant-panel-form')).not.toBeNull();
|
||||
expect(container.querySelector('.assistant-panel-card')).not.toBeNull();
|
||||
expect(container.querySelector('.assistant-panel-image')).not.toBeNull();
|
||||
expect(container.querySelector('.assistant-panel-tabs')).not.toBeNull();
|
||||
});
|
||||
|
||||
it('enforces action confirmation policy before dispatching assistant actions', () => {
|
||||
const onAction = vi.fn();
|
||||
const confirmMock = vi.fn().mockReturnValue(true);
|
||||
Object.defineProperty(window, 'confirm', {
|
||||
value: confirmMock,
|
||||
configurable: true,
|
||||
});
|
||||
|
||||
const { getByText } = render(
|
||||
React.createElement(AssistantPanelControls, {
|
||||
elements: [{ type: 'action', label: 'Open Settings', action: 'openSettings' }],
|
||||
actionPolicies: { openSettings: 'confirm' },
|
||||
onAction,
|
||||
}),
|
||||
);
|
||||
|
||||
fireEvent.click(getByText('Open Settings'));
|
||||
|
||||
expect(confirmMock).toHaveBeenCalledTimes(1);
|
||||
expect(onAction).toHaveBeenCalledWith('openSettings', undefined);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user