chore: refactorings and code sharing

2026-02-22 09:20:22 +01:00
parent 653e79dd70
commit 2a73db57b4
12 changed files with 1587 additions and 1158 deletions
--- a/tests/engine/SiteValidationDiffService.test.ts
+++ b/tests/engine/SiteValidationDiffService.test.ts
@@ -0,0 +1,66 @@
+import { mkdir, writeFile } from 'node:fs/promises';
+import path from 'node:path';
+import { describe, expect, it } from 'vitest';
+import { compareSitemapToHtml } from '../../src/main/engine/SiteValidationDiffService';
+
+function makeTempName(): string {
+  return `bds-site-validation-${Date.now()}-${Math.random().toString(36).slice(2)}`;
+}
+
+describe('SiteValidationDiffService', () => {
+  it('computes missing and extra URL paths from sitemap xml and html tree', async () => {
+    const tempRoot = path.join('/tmp', makeTempName());
+    const htmlDir = path.join(tempRoot, 'html');
+
+    await mkdir(path.join(htmlDir, 'category', 'news', 'page', '2'), { recursive: true });
+    await mkdir(path.join(htmlDir, 'stale'), { recursive: true });
+    await writeFile(path.join(htmlDir, 'index.html'), '<html>root</html>', 'utf-8');
+    await writeFile(path.join(htmlDir, 'category', 'news', 'index.html'), '<html>news</html>', 'utf-8');
+    await writeFile(path.join(htmlDir, 'category', 'news', 'page', '2', 'index.html'), '<html>news p2</html>', 'utf-8');
+    await writeFile(path.join(htmlDir, 'stale', 'index.html'), '<html>stale</html>', 'utf-8');
+
+    const sitemapXml = [
+      '<?xml version="1.0" encoding="UTF-8"?>',
+      '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">',
+      '  <url><loc>https://example.com/</loc></url>',
+      '  <url><loc>https://example.com/category/news/</loc></url>',
+      '  <url><loc>https://example.com/category/news/page/2/</loc></url>',
+      '  <url><loc>https://example.com/tag/dev/</loc></url>',
+      '</urlset>',
+      '',
+    ].join('\n');
+
+    const result = await compareSitemapToHtml({
+      sitemapXml,
+      baseUrl: 'https://example.com',
+      htmlDir,
+    });
+
+    expect(result.missingUrlPaths).toEqual(['/tag/dev']);
+    expect(result.extraUrlPaths).toEqual(['/stale']);
+    expect(result.expectedUrlCount).toBe(4);
+    expect(result.existingHtmlUrlCount).toBe(4);
+  });
+
+  it('normalizes base path urls and tolerates missing html dir', async () => {
+    const sitemapXml = [
+      '<?xml version="1.0" encoding="UTF-8"?>',
+      '<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">',
+      '  <url><loc>https://example.com/blog/</loc></url>',
+      '  <url><loc>https://example.com/blog/page/2/</loc></url>',
+      '</urlset>',
+      '',
+    ].join('\n');
+
+    const result = await compareSitemapToHtml({
+      sitemapXml,
+      baseUrl: 'https://example.com/blog',
+      htmlDir: path.join('/tmp', makeTempName(), 'missing-html-dir'),
+    });
+
+    expect(result.missingUrlPaths).toEqual(['/', '/page/2']);
+    expect(result.extraUrlPaths).toEqual([]);
+    expect(result.expectedUrlCount).toBe(2);
+    expect(result.existingHtmlUrlCount).toBe(0);
+  });
+});