wip: first run of implementation

2026-02-25 20:29:01 +01:00
parent 2e203fa3a9
commit 20ea499a6f
40 changed files with 2170 additions and 22 deletions
--- a/src/renderer/components/AssistantPanelControls/AssistantPanelControls.tsx
+++ b/src/renderer/components/AssistantPanelControls/AssistantPanelControls.tsx
@@ -5,9 +5,10 @@ import './AssistantPanelControls.css';
 interface AssistantPanelControlsProps {
  elements: AssistantPanelElement[];
  onAction: (action: string, payload?: Record<string, unknown>) => void;
+  actionPolicies?: Record<string, 'silent' | 'confirm' | 'danger'>;
 }

-export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({ elements, onAction }) => {
+export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({ elements, onAction, actionPolicies = {} }) => {
  const [widgetValues, setWidgetValues] = useState<Record<string, unknown>>({});
  const [activeTabByWidget, setActiveTabByWidget] = useState<Record<string, string>>({});

@@ -21,6 +22,20 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
  const getWidgetValue = (key: string, defaultValue?: unknown) =>
    Object.prototype.hasOwnProperty.call(widgetValues, key) ? widgetValues[key] : defaultValue;

+  const triggerAction = (action: string, payload?: Record<string, unknown>, label?: string) => {
+    const policy = actionPolicies[action] || 'silent';
+
+    if (policy !== 'silent') {
+      const confirmationText = label || action;
+      const confirmed = window.confirm(confirmationText);
+      if (!confirmed) {
+        return;
+      }
+    }
+
+    onAction(action, payload);
+  };
+
  const renderInputControl = (
    key: string,
    label: string,
@@ -150,7 +165,7 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
          {element.action && element.submitLabel && (
            <button
              type="button"
-              onClick={() => onAction(element.action!, { ...(element.payload ?? {}), [element.key]: currentValue })}
+              onClick={() => triggerAction(element.action!, { ...(element.payload ?? {}), [element.key]: currentValue }, element.submitLabel)}
            >
              {element.submitLabel}
            </button>
@@ -175,7 +190,7 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
          {element.action && element.submitLabel && (
            <button
              type="button"
-              onClick={() => onAction(element.action!, { ...(element.payload ?? {}), [element.key]: currentValue })}
+              onClick={() => triggerAction(element.action!, { ...(element.payload ?? {}), [element.key]: currentValue }, element.submitLabel)}
            >
              {element.submitLabel}
            </button>
@@ -191,11 +206,11 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
          return accumulator;
        }, {});

-        onAction(element.action, {
+        triggerAction(element.action, {
          ...(element.payload ?? {}),
          formId: element.formId,
          values,
-        });
+        }, element.submitLabel);
      };

      return (
@@ -224,7 +239,7 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
                <button
                  key={`assistant-card-action-${indexPath}-${actionIndex}`}
                  type="button"
-                  onClick={() => onAction(action.action, action.payload)}
+                  onClick={() => triggerAction(action.action, action.payload, action.label)}
                >
                  {action.label}
                </button>
@@ -243,7 +258,7 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
            alt={element.alt || ''}
            onClick={() => {
              if (element.action) {
-                onAction(element.action, element.payload);
+                triggerAction(element.action, element.payload, element.caption || element.alt || element.action);
              }
            }}
          />
@@ -279,7 +294,7 @@ export const AssistantPanelControls: React.FC<AssistantPanelControlsProps> = ({
    }

    return (
-      <button key={`assistant-element-${indexPath}`} type="button" onClick={() => onAction(element.action, element.payload)}>
+      <button key={`assistant-element-${indexPath}`} type="button" onClick={() => triggerAction(element.action, element.payload, element.label)}>
        {element.label}
      </button>
    );
--- a/src/renderer/components/AssistantSidebar/AssistantSidebar.tsx
+++ b/src/renderer/components/AssistantSidebar/AssistantSidebar.tsx
@@ -4,6 +4,7 @@ import { resolveAssistantEditorContext } from '../../navigation/assistantPromptC
 import { planAssistantRequest } from '../../navigation/assistantConversation';
 import { dispatchAssistantAction } from '../../navigation/assistantActionDispatcher';
 import { extractAssistantResponseContent, type AssistantPanelElement } from '../../navigation/assistantPanelSpec';
+import { toClarificationElements } from '../../navigation/protocolNeedsInput';
 import { ensureConversationId } from '../../navigation/chatSession';
 import { getChatSurfaceMode } from '../../navigation/chatSurfaceMode';
 import { useChatMessageSender } from '../../navigation/useChatMessageSender';
@@ -22,6 +23,7 @@ export const AssistantSidebar: React.FC = () => {
  const [errorMessage, setErrorMessage] = useState<string | null>(null);
  const [conversationId, setConversationId] = useState<string | null>(null);
  const [panelElements, setPanelElements] = useState<AssistantPanelElement[]>([]);
+  const [actionPolicies, setActionPolicies] = useState<Record<string, 'silent' | 'confirm' | 'danger'>>({});
  const [actionError, setActionError] = useState<string | null>(null);

  const {
@@ -127,10 +129,23 @@ export const AssistantSidebar: React.FC = () => {
        throw new Error(sendResult.error || 'Failed to send assistant message');
      }

-      if (sendResult.message) {
+      if (sendResult.envelope) {
+        finalizeAssistantTurn(resolvedConversationId, sendResult.envelope.assistantText);
+        const uiElements = Array.isArray(sendResult.envelope.ui?.elements)
+          ? (sendResult.envelope.ui?.elements as AssistantPanelElement[])
+          : toClarificationElements(sendResult.envelope.needsInput);
+        setPanelElements(uiElements);
+        setActionPolicies(
+          sendResult.envelope.actions.reduce<Record<string, 'silent' | 'confirm' | 'danger'>>((accumulator, action) => {
+            accumulator[action.action] = action.policy;
+            return accumulator;
+          }, {}),
+        );
+      } else if (sendResult.message) {
        const parsedResponse = extractAssistantResponseContent(sendResult.message);
        finalizeAssistantTurn(resolvedConversationId, parsedResponse.displayText);
        setPanelElements(parsedResponse.panelSpec?.elements ?? []);
+        setActionPolicies({});
      } else {
        appendAssistantMessage(resolvedConversationId, tr('chat.errorEmptyResponse'));
        stopStreaming();
@@ -146,6 +161,61 @@ export const AssistantSidebar: React.FC = () => {
  };

  const handleAssistantAction = (action: string, payload?: Record<string, unknown>) => {
+    if (action === 'submitNeedsInput' && conversationId) {
+      const values = payload?.values;
+      if (!values || typeof values !== 'object') {
+        setActionError(tr('assistantSidebar.error.actionFailed'));
+        return;
+      }
+
+      const clarificationMessage = `needs_input_response: ${JSON.stringify(values)}`;
+
+      beginUserTurn(conversationId, clarificationMessage);
+
+      void sendChatMessage({
+        conversationId,
+        message: clarificationMessage,
+        metadata: { surface: 'sidebar' },
+      }).then((sendResult) => {
+        if (!sendResult.success) {
+          appendAssistantMessage(
+            conversationId,
+            tr('chat.errorPrefix', { error: sendResult.error || tr('chat.errorNoResponse') }),
+          );
+          stopStreaming();
+          return;
+        }
+
+        if (sendResult.envelope) {
+          finalizeAssistantTurn(conversationId, sendResult.envelope.assistantText);
+          const uiElements = Array.isArray(sendResult.envelope.ui?.elements)
+            ? (sendResult.envelope.ui?.elements as AssistantPanelElement[])
+            : toClarificationElements(sendResult.envelope.needsInput);
+          setPanelElements(uiElements);
+          setActionPolicies(
+            sendResult.envelope.actions.reduce<Record<string, 'silent' | 'confirm' | 'danger'>>((accumulator, action) => {
+              accumulator[action.action] = action.policy;
+              return accumulator;
+            }, {}),
+          );
+          return;
+        }
+
+        if (sendResult.message) {
+          const parsedResponse = extractAssistantResponseContent(sendResult.message);
+          finalizeAssistantTurn(conversationId, parsedResponse.displayText);
+          setPanelElements(parsedResponse.panelSpec?.elements ?? []);
+          setActionPolicies({});
+        }
+      }).catch((error) => {
+        console.error('Failed to submit assistant clarification:', error);
+        appendAssistantMessage(conversationId, tr('chat.errorGeneric'));
+        stopStreaming();
+      });
+
+      return;
+    }
+
    const result = dispatchAssistantAction(
      {
        action,
@@ -230,7 +300,7 @@ export const AssistantSidebar: React.FC = () => {
      )}

      {panelElements.length > 0 && (
-        <AssistantPanelControls elements={panelElements} onAction={handleAssistantAction} />
+        <AssistantPanelControls elements={panelElements} onAction={handleAssistantAction} actionPolicies={actionPolicies} />
      )}
    </div>
  );
--- a/src/renderer/components/ChatPanel/ChatPanel.tsx
+++ b/src/renderer/components/ChatPanel/ChatPanel.tsx
@@ -5,6 +5,7 @@ import { useChatSurfaceState } from '../../navigation/useChatSurfaceState';
 import { getChatSurfaceMode } from '../../navigation/chatSurfaceMode';
 import { dispatchAssistantAction } from '../../navigation/assistantActionDispatcher';
 import { extractAssistantResponseContent, type AssistantPanelElement } from '../../navigation/assistantPanelSpec';
+import { toClarificationElements } from '../../navigation/protocolNeedsInput';
 import { useAppStore } from '../../store';
 import { ChatTranscript } from '../ChatSurface';
 import { AssistantPanelControls } from '../AssistantPanelControls';
@@ -28,6 +29,7 @@ export const ChatPanel: React.FC<ChatPanelProps> = ({ conversationId }) => {
  const [apiKeyError, setApiKeyError] = useState('');
  const [isValidating, setIsValidating] = useState(false);
  const [panelElements, setPanelElements] = useState<AssistantPanelElement[]>([]);
+  const [actionPolicies, setActionPolicies] = useState<Record<string, 'silent' | 'confirm' | 'danger'>>({});
  const [actionError, setActionError] = useState<string | null>(null);
  const messagesEndRef = useRef<HTMLDivElement>(null);
  const inputRef = useRef<HTMLTextAreaElement>(null);
@@ -190,21 +192,36 @@ export const ChatPanel: React.FC<ChatPanelProps> = ({ conversationId }) => {
      // Fall back to the backend result message if streaming didn't capture the content
      const assistantContent = getStreamingContent() || (result.success ? result.message : '');

-      if (assistantContent) {
+      if (result.envelope) {
+        finalizeAssistantTurn(conversationId, result.envelope.assistantText);
+        const uiElements = Array.isArray(result.envelope.ui?.elements)
+          ? (result.envelope.ui?.elements as AssistantPanelElement[])
+          : toClarificationElements(result.envelope.needsInput);
+        setPanelElements(uiElements);
+        setActionPolicies(
+          result.envelope.actions.reduce<Record<string, 'silent' | 'confirm' | 'danger'>>((accumulator, action) => {
+            accumulator[action.action] = action.policy;
+            return accumulator;
+          }, {}),
+        );
+      } else if (assistantContent) {
        const parsedResponse = extractAssistantResponseContent(assistantContent);
        finalizeAssistantTurn(conversationId, parsedResponse.displayText);
        setPanelElements(parsedResponse.panelSpec?.elements ?? []);
+        setActionPolicies({});
      } else if (!result.success) {
        // Backend returned an error (API failure, model unavailable, etc.)
        appendAssistantMessage(conversationId, tr('chat.errorPrefix', { error: result.error || tr('chat.errorNoResponse') }));
        stopStreaming();
        setPanelElements([]);
+        setActionPolicies({});
      } else {
        // No content from streaming AND no error, but also no success message
        // This can happen with some models that don't return content properly
        appendAssistantMessage(conversationId, tr('chat.errorEmptyResponse'));
        stopStreaming();
        setPanelElements([]);
+        setActionPolicies({});
      }
    } catch (error) {
      console.error('Failed to send message:', error);
@@ -226,7 +243,64 @@ export const ChatPanel: React.FC<ChatPanelProps> = ({ conversationId }) => {
    }
  };

+  const handleNeedsInputSubmit = async (payload?: Record<string, unknown>) => {
+    const values = payload?.values;
+    if (!values || typeof values !== 'object') {
+      setActionError(tr('assistantSidebar.error.actionFailed'));
+      return;
+    }
+
+    const clarificationMessage = `needs_input_response: ${JSON.stringify(values)}`;
+    beginUserTurn(conversationId, clarificationMessage);
+
+    try {
+      const result = await sendChatMessage({
+        conversationId,
+        message: clarificationMessage,
+        metadata: { surface: 'tab' },
+      });
+
+      if (!result.success) {
+        appendAssistantMessage(conversationId, tr('chat.errorPrefix', { error: result.error || tr('chat.errorNoResponse') }));
+        stopStreaming();
+        return;
+      }
+
+      if (result.envelope) {
+        finalizeAssistantTurn(conversationId, result.envelope.assistantText);
+        const uiElements = Array.isArray(result.envelope.ui?.elements)
+          ? (result.envelope.ui?.elements as AssistantPanelElement[])
+          : toClarificationElements(result.envelope.needsInput);
+        setPanelElements(uiElements);
+        setActionPolicies(
+          result.envelope.actions.reduce<Record<string, 'silent' | 'confirm' | 'danger'>>((accumulator, action) => {
+            accumulator[action.action] = action.policy;
+            return accumulator;
+          }, {}),
+        );
+        return;
+      }
+
+      const assistantContent = getStreamingContent() || result.message;
+      if (assistantContent) {
+        const parsedResponse = extractAssistantResponseContent(assistantContent);
+        finalizeAssistantTurn(conversationId, parsedResponse.displayText);
+        setPanelElements(parsedResponse.panelSpec?.elements ?? []);
+        setActionPolicies({});
+      }
+    } catch (error) {
+      console.error('Failed to submit clarification:', error);
+      appendAssistantMessage(conversationId, tr('chat.errorGeneric'));
+      stopStreaming();
+    }
+  };
+
  const handleAssistantAction = (action: string, payload?: Record<string, unknown>) => {
+    if (action === 'submitNeedsInput') {
+      void handleNeedsInputSubmit(payload);
+      return;
+    }
+
    const result = dispatchAssistantAction(
      {
        action,
@@ -377,7 +451,7 @@ export const ChatPanel: React.FC<ChatPanelProps> = ({ conversationId }) => {
        />

        {panelElements.length > 0 && (
-          <AssistantPanelControls elements={panelElements} onAction={handleAssistantAction} />
+          <AssistantPanelControls elements={panelElements} onAction={handleAssistantAction} actionPolicies={actionPolicies} />
        )}

        {actionError && <p className="chat-surface-error">{actionError}</p>}
--- a/src/renderer/components/Editor/Editor.tsx
+++ b/src/renderer/components/Editor/Editor.tsx
@@ -1478,6 +1478,12 @@ interface CategoryCount {
  count: number;
 }

+interface DashboardProtocolHealth {
+  blockedActionCount: number;
+  parseValidityRate: number;
+  fallbackTurns: number;
+}
+
 const Dashboard: React.FC = () => {
  const { t: tr, language } = useI18n();
  const { posts, media } = useAppStore();
@@ -1486,6 +1492,7 @@ const Dashboard: React.FC = () => {
  const [tagCounts, setTagCounts] = useState<TagCount[]>([]);
  const [tagColors, setTagColors] = useState<Map<string, string>>(new Map());
  const [categoryCounts, setCategoryCounts] = useState<CategoryCount[]>([]);
+  const [protocolHealth, setProtocolHealth] = useState<DashboardProtocolHealth | null>(null);

  const uiDateLocale = UI_DATE_LOCALE[language] || UI_DATE_LOCALE.en;
  const monthFormatter = useMemo(
@@ -1496,17 +1503,25 @@ const Dashboard: React.FC = () => {
  useEffect(() => {
    const loadStats = async () => {
      try {
-        const [ds, ym, tc, cc, colorMap] = await Promise.all([
+        const [ds, ym, tc, cc, colorMap, protocolHealthSnapshot] = await Promise.all([
          window.electronAPI?.posts.getDashboardStats(),
          window.electronAPI?.posts.getByYearMonth(),
          window.electronAPI?.posts.getTagsWithCounts(),
          window.electronAPI?.posts.getCategoriesWithCounts(),
          loadTagColorMap(),
+          window.electronAPI?.chat.getProtocolHealth(),
        ]);
        if (ds) setStats(ds);
        if (ym) setYearMonthData(ym);
        if (tc) setTagCounts(tc);
        if (cc) setCategoryCounts(cc);
+        if (protocolHealthSnapshot) {
+          setProtocolHealth({
+            blockedActionCount: protocolHealthSnapshot.blockedActionCount,
+            parseValidityRate: protocolHealthSnapshot.parseValidityRate,
+            fallbackTurns: protocolHealthSnapshot.fallbackTurns,
+          });
+        }
        setTagColors(colorMap);
      } catch (e) {
        console.error('Failed to load dashboard stats:', e);
@@ -1551,6 +1566,9 @@ const Dashboard: React.FC = () => {
  const displayDraftCount = stats?.draftCount ?? 0;
  const displayPublishedCount = stats?.publishedCount ?? 0;
  const displayArchivedCount = stats?.archivedCount ?? 0;
+  const parseValidityPercent = protocolHealth
+    ? `${Math.round(protocolHealth.parseValidityRate * 100)}%`
+    : '—';

  const getPostCountLabel = useCallback((count: number) => {
    return tr(count === 1 ? 'dashboard.postCount.one' : 'dashboard.postCount.other', { count });
@@ -1597,6 +1615,14 @@ const Dashboard: React.FC = () => {
              <span className="stat-tag">{tr('dashboard.stats.categories', { count: categoryCounts.length })}</span>
            </div>
          </div>
+          <div className="stat-card">
+            <div className="stat-number">{parseValidityPercent}</div>
+            <div className="stat-label">{tr('dashboard.stats.protocolHealth')}</div>
+            <div className="stat-breakdown">
+              <span className="stat-tag">{tr('dashboard.stats.blockedActions', { count: protocolHealth?.blockedActionCount ?? 0 })}</span>
+              <span className="stat-tag">{tr('dashboard.stats.fallbackTurns', { count: protocolHealth?.fallbackTurns ?? 0 })}</span>
+            </div>
+          </div>
        </div>

        {timelineEntries.length > 0 && (