Ten variants of Message in crates/bds-ui/src/app.rs have match arms in update() but are never constructed anywhere in the workspace (verified: no Message::X, Self::X, or aliased construction sites): ClearTabs, PinTab, PostLoaded, MediaLoaded, ScriptLoaded, TemplateLoaded, ShowToast, ProjectCreated, ProjectDeleted, ProjectSwitched. They are dead plumbing left from earlier load/CRUD flows that were since replaced by the direct handler paths (project switching now goes through the engine handlers, entity loads happen synchronously on tab open).
AGENTS rule: don't leave unused code in the codebase.
Task
For each of the ten variants, first confirm it is still unconstructed (grep -rn "Message::<Name>\|Self::<Name>" crates/), then delete the enum variant and its match arm plus any helper functions or types only reachable from that arm.
If deleting a handler orphans further private functions (e.g. a load-result application helper used only by PostLoaded), delete those too, recursively.
Do not change behavior: no handler that is actually reachable may be touched.
Build and run cargo test --workspace; fix any test that constructed these variants directly by removing/adjusting the test (a test constructing a dead variant is testing dead code).
Definition of done
The ten variants are gone, the workspace compiles with no new warnings, and cargo test --workspace passes.
## Context
Ten variants of `Message` in `crates/bds-ui/src/app.rs` have match arms in `update()` but are never constructed anywhere in the workspace (verified: no `Message::X`, `Self::X`, or aliased construction sites): `ClearTabs`, `PinTab`, `PostLoaded`, `MediaLoaded`, `ScriptLoaded`, `TemplateLoaded`, `ShowToast`, `ProjectCreated`, `ProjectDeleted`, `ProjectSwitched`. They are dead plumbing left from earlier load/CRUD flows that were since replaced by the direct handler paths (project switching now goes through the engine handlers, entity loads happen synchronously on tab open).
AGENTS rule: don't leave unused code in the codebase.
## Task
1. For each of the ten variants, first confirm it is still unconstructed (`grep -rn "Message::<Name>\|Self::<Name>" crates/`), then delete the enum variant and its match arm plus any helper functions or types only reachable from that arm.
2. If deleting a handler orphans further private functions (e.g. a load-result application helper used only by `PostLoaded`), delete those too, recursively.
3. Do not change behavior: no handler that is actually reachable may be touched.
4. Build and run `cargo test --workspace`; fix any test that constructed these variants directly by removing/adjusting the test (a test constructing a dead variant is testing dead code).
## Definition of done
- The ten variants are gone, the workspace compiles with no new warnings, and `cargo test --workspace` passes.
hugo
added the bug label 2026-07-20 10:40:07 +00:00
Implemented in b10212d. Removed the ten unconstructed Message variants and their unreachable update arms: ClearTabs, PinTab, PostLoaded, MediaLoaded, ScriptLoaded, TemplateLoaded, ShowToast, ProjectCreated, ProjectDeleted, and ProjectSwitched. A recursive reachability review confirmed that tab pinning, project lifecycle operations, editor loading, and toast behavior remain reachable through their live direct paths, so no behavior or Allium/bDS2 semantics changed. Verification passed: exact-symbol search, rustfmt check, cargo check/test for bds-ui, strict workspace clippy, workspace build/test, Allium check/analyse, cargo machete, and cargo outdated.
Implemented in b10212d. Removed the ten unconstructed Message variants and their unreachable update arms: ClearTabs, PinTab, PostLoaded, MediaLoaded, ScriptLoaded, TemplateLoaded, ShowToast, ProjectCreated, ProjectDeleted, and ProjectSwitched. A recursive reachability review confirmed that tab pinning, project lifecycle operations, editor loading, and toast behavior remain reachable through their live direct paths, so no behavior or Allium/bDS2 semantics changed. Verification passed: exact-symbol search, rustfmt check, cargo check/test for bds-ui, strict workspace clippy, workspace build/test, Allium check/analyse, cargo machete, and cargo outdated.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
Ten variants of
Messageincrates/bds-ui/src/app.rshave match arms inupdate()but are never constructed anywhere in the workspace (verified: noMessage::X,Self::X, or aliased construction sites):ClearTabs,PinTab,PostLoaded,MediaLoaded,ScriptLoaded,TemplateLoaded,ShowToast,ProjectCreated,ProjectDeleted,ProjectSwitched. They are dead plumbing left from earlier load/CRUD flows that were since replaced by the direct handler paths (project switching now goes through the engine handlers, entity loads happen synchronously on tab open).AGENTS rule: don't leave unused code in the codebase.
Task
grep -rn "Message::<Name>\|Self::<Name>" crates/), then delete the enum variant and its match arm plus any helper functions or types only reachable from that arm.PostLoaded), delete those too, recursively.cargo test --workspace; fix any test that constructed these variants directly by removing/adjusting the test (a test constructing a dead variant is testing dead code).Definition of done
cargo test --workspacepasses.Implemented in
b10212d. Removed the ten unconstructed Message variants and their unreachable update arms: ClearTabs, PinTab, PostLoaded, MediaLoaded, ScriptLoaded, TemplateLoaded, ShowToast, ProjectCreated, ProjectDeleted, and ProjectSwitched. A recursive reachability review confirmed that tab pinning, project lifecycle operations, editor loading, and toast behavior remain reachable through their live direct paths, so no behavior or Allium/bDS2 semantics changed. Verification passed: exact-symbol search, rustfmt check, cargo check/test for bds-ui, strict workspace clippy, workspace build/test, Allium check/analyse, cargo machete, and cargo outdated.