The TUI settings panel has a "Style" section (crates/bds-server/src/tui.rs, SettingSection::Style, around line 2072) offering "Theme (system/light/dark)" and "Content width" fields backed by the global settings keys style.theme and style.content_width (defaults in crates/bds-core/src/engine/settings.rs lines 38–39). No code anywhere reads these values — the section edits dead settings. The real Style concept is the project picoTheme (Pico CSS theme), and per decision the Pico theme editor is GUI-only (separate issue).
Task
Remove SettingSection::Style from the TUI: the enum variant, its entry in SettingSection::ALL, the field_specs arm, the label mapping (settings.nav.style in the TUI section labels), and the field-label keys tui.settingTheme / tui.settingContentWidth from all five locales/ui/*.ftl files if nothing else uses them.
Remove the dead default settings keys style.theme and style.content_width from crates/bds-core/src/engine/settings.rs. Check bds-cli config output paths and any settings listing tests that enumerate defaults and update them.
Update specs/tui.alliumSettingsPanel rule: the section list becomes Project, Editor, Content, AI, Technology, Publishing, Data, MCP (drop Style). Validate with the installed allium CLI (allium check specs/*.allium — no new warnings).
Note: do NOT remove the GUI settings-sidebar settings.nav.style entry — the GUI keeps the Style tab (Pico theme editor).
Definition of done
TUI settings show 8 sections; no style.* keys remain in code, defaults, or locales (except GUI nav/tab labels).
cargo test --workspace passes; allium check clean.
## Context
The TUI settings panel has a "Style" section (`crates/bds-server/src/tui.rs`, `SettingSection::Style`, around line 2072) offering "Theme (system/light/dark)" and "Content width" fields backed by the global settings keys `style.theme` and `style.content_width` (defaults in `crates/bds-core/src/engine/settings.rs` lines 38–39). **No code anywhere reads these values** — the section edits dead settings. The real Style concept is the project `picoTheme` (Pico CSS theme), and per decision the Pico theme editor is GUI-only (separate issue).
## Task
1. Remove `SettingSection::Style` from the TUI: the enum variant, its entry in `SettingSection::ALL`, the `field_specs` arm, the label mapping (`settings.nav.style` in the TUI section labels), and the field-label keys `tui.settingTheme` / `tui.settingContentWidth` from all five `locales/ui/*.ftl` files if nothing else uses them.
2. Remove the dead default settings keys `style.theme` and `style.content_width` from `crates/bds-core/src/engine/settings.rs`. Check `bds-cli config` output paths and any settings listing tests that enumerate defaults and update them.
3. Update `specs/tui.allium` `SettingsPanel` rule: the section list becomes Project, Editor, Content, AI, Technology, Publishing, Data, MCP (drop Style). Validate with the installed `allium` CLI (`allium check specs/*.allium` — no new warnings).
4. Note: do NOT remove the GUI settings-sidebar `settings.nav.style` entry — the GUI keeps the Style tab (Pico theme editor).
## Definition of done
- TUI settings show 8 sections; no `style.*` keys remain in code, defaults, or locales (except GUI nav/tab labels).
- `cargo test --workspace` passes; `allium check` clean.
hugo
added the bug label 2026-07-20 10:39:47 +00:00
Implemented in 25fe22a. Removed the dead TUI Style section so the panel now exposes exactly Project, Editor, Content, AI, Technology, Publishing, Data, and MCP; removed the style.theme and style.content_width defaults and their TUI labels from all five locales; and updated specs/tui.allium while preserving the GUI-only Style tab. Added regression coverage at the core defaults, CLI config listing, and TUI section/field boundaries. Verified against the issue, the bDS2 baseline, and the Allium contract with no completeness gaps found. Gates passed: allium check and analyse, cargo fmt --all --check, cargo machete --with-metadata, cargo outdated --workspace --root-deps-only --exit-code 1, cargo clippy --workspace --all-targets -- -D warnings, cargo build --workspace, cargo test --workspace, i18n completeness, and git diff --check.
Implemented in 25fe22a. Removed the dead TUI Style section so the panel now exposes exactly Project, Editor, Content, AI, Technology, Publishing, Data, and MCP; removed the style.theme and style.content_width defaults and their TUI labels from all five locales; and updated specs/tui.allium while preserving the GUI-only Style tab. Added regression coverage at the core defaults, CLI config listing, and TUI section/field boundaries. Verified against the issue, the bDS2 baseline, and the Allium contract with no completeness gaps found. Gates passed: allium check and analyse, cargo fmt --all --check, cargo machete --with-metadata, cargo outdated --workspace --root-deps-only --exit-code 1, cargo clippy --workspace --all-targets -- -D warnings, cargo build --workspace, cargo test --workspace, i18n completeness, and git diff --check.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
The TUI settings panel has a "Style" section (
crates/bds-server/src/tui.rs,SettingSection::Style, around line 2072) offering "Theme (system/light/dark)" and "Content width" fields backed by the global settings keysstyle.themeandstyle.content_width(defaults incrates/bds-core/src/engine/settings.rslines 38–39). No code anywhere reads these values — the section edits dead settings. The real Style concept is the projectpicoTheme(Pico CSS theme), and per decision the Pico theme editor is GUI-only (separate issue).Task
SettingSection::Stylefrom the TUI: the enum variant, its entry inSettingSection::ALL, thefield_specsarm, the label mapping (settings.nav.stylein the TUI section labels), and the field-label keystui.settingTheme/tui.settingContentWidthfrom all fivelocales/ui/*.ftlfiles if nothing else uses them.style.themeandstyle.content_widthfromcrates/bds-core/src/engine/settings.rs. Checkbds-cli configoutput paths and any settings listing tests that enumerate defaults and update them.specs/tui.alliumSettingsPanelrule: the section list becomes Project, Editor, Content, AI, Technology, Publishing, Data, MCP (drop Style). Validate with the installedalliumCLI (allium check specs/*.allium— no new warnings).settings.nav.styleentry — the GUI keeps the Style tab (Pico theme editor).Definition of done
style.*keys remain in code, defaults, or locales (except GUI nav/tab labels).cargo test --workspacepasses;allium checkclean.Implemented in
25fe22a. Removed the dead TUI Style section so the panel now exposes exactly Project, Editor, Content, AI, Technology, Publishing, Data, and MCP; removed the style.theme and style.content_width defaults and their TUI labels from all five locales; and updated specs/tui.allium while preserving the GUI-only Style tab. Added regression coverage at the core defaults, CLI config listing, and TUI section/field boundaries. Verified against the issue, the bDS2 baseline, and the Allium contract with no completeness gaps found. Gates passed: allium check and analyse, cargo fmt --all --check, cargo machete --with-metadata, cargo outdated --workspace --root-deps-only --exit-code 1, cargo clippy --workspace --all-targets -- -D warnings, cargo build --workspace, cargo test --workspace, i18n completeness, and git diff --check.