Audit public API and SemVer surface (#103)

crates/libremetaverse/src/caps_http.rs

@@ -557,7 +557,7 @@ struct HttpCapsClientInner {
     disposed: AtomicBool,
 }
 
-/// Native capability HTTP client with injectable fake and reqwest backends.
+/// Native capability HTTP client with injectable fake and production backends.
 #[derive(Clone)]
 pub struct HttpCapsClient(Arc<HttpCapsClientInner>);
 
@@ -614,24 +614,47 @@ impl HttpCapsClient {
         })))
     }
 
-    pub fn with_reqwest_client(
-        client: reqwest::Client,
+    /// Creates the production HTTP backend without exposing the selected HTTP
+    /// implementation in the public API.
+    pub fn with_native_transport(
+        user_agent: &str,
+        timeout: Duration,
+        max_connections: usize,
         rate_limiter: Option<CapsRateLimiter>,
         limits: CapsHttpLimits,
     ) -> Result<Self, Error> {
-        Self::with_reqwest_client_and_concurrency(client, rate_limiter, limits, 32)
+        if timeout.is_zero() || max_connections == 0 {
+            return Err(Error::Argument);
+        }
+        limits.validate()?;
+        let max_redirects = limits.max_redirects;
+        let redirect = reqwest::redirect::Policy::custom(move |attempt| {
+            if attempt.previous().len() >= max_redirects {
+                return attempt.stop();
+            }
+            match attempt.url().scheme() {
+                "http" | "https" => attempt.follow(),
+                _ => attempt.stop(),
+            }
+        });
+        let client = reqwest::Client::builder()
+            .redirect(redirect)
+            .timeout(timeout)
+            .connect_timeout(timeout)
+            .pool_max_idle_per_host(max_connections)
+            .user_agent(user_agent)
+            .build()
+            .map_err(|_| Error::HttpRequest)?;
+        Self::with_reqwest_client(client, rate_limiter, limits, max_connections)
     }
 
-    fn with_reqwest_client_and_concurrency(
+    fn with_reqwest_client(
         client: reqwest::Client,
         rate_limiter: Option<CapsRateLimiter>,
         limits: CapsHttpLimits,
         max_connections: usize,
     ) -> Result<Self, Error> {
         limits.validate()?;
-        if max_connections == 0 {
-            return Err(Error::Argument);
-        }
         Ok(Self(Arc::new(HttpCapsClientInner {
             backend: HttpBackend::Reqwest(client),
             limits,
@@ -648,33 +671,12 @@ impl HttpCapsClient {
         max_connections: usize,
         rate_limiter: CapsRateLimiter,
     ) -> Result<Self, Error> {
-        if max_connections == 0 {
-            return Err(Error::Argument);
-        }
-        let limits = CapsHttpLimits::default();
-        let max_redirects = limits.max_redirects;
-        let redirect = reqwest::redirect::Policy::custom(move |attempt| {
-            if attempt.previous().len() > max_redirects {
-                return attempt.stop();
-            }
-            match attempt.url().scheme() {
-                "http" | "https" => attempt.follow(),
-                _ => attempt.stop(),
-            }
-        });
-        let client = reqwest::Client::builder()
-            .redirect(redirect)
-            .timeout(timeout)
-            .connect_timeout(timeout)
-            .pool_max_idle_per_host(max_connections)
-            .user_agent(user_agent)
-            .build()
-            .map_err(|_| Error::HttpRequest)?;
-        Self::with_reqwest_client_and_concurrency(
-            client,
-            Some(rate_limiter),
-            limits,
+        Self::with_native_transport(
+            user_agent,
+            timeout,
             max_connections,
+            Some(rate_limiter),
+            CapsHttpLimits::default(),
         )
     }