Complete first release candidate audit (#107)

tools/performance/src/main.rs

@@ -2,6 +2,7 @@
 
 use std::alloc::System;
 use std::collections::{BTreeMap, BTreeSet, HashMap};
+use std::fmt::Write as _;
 use std::fs;
 use std::hint::black_box;
 use std::path::Path;
@@ -487,7 +488,7 @@ fn uuid_math(context: &Context, iterations: usize) -> AppResult<u64> {
         let parsed = UUID::new_with_string(context.fixture.uuid.clone()).map_err(debug)?;
         matrix = Matrix4::transform(matrix, rotation).map_err(debug)?;
         checksum ^=
-            parsed.get_u_long().map_err(debug)? ^ matrix.m41.to_bits() as u64 ^ index as u64;
+            parsed.get_u_long().map_err(debug)? ^ u64::from(matrix.m41.to_bits()) ^ index as u64;
     }
     Ok(checksum)
 }
@@ -509,17 +510,17 @@ macro_rules! llsd_workload {
 llsd_workload!(
     llsd_xml,
     |value: &OSD| OSDParser::serialize_llsd_xml_bytes(value.clone()),
-    |bytes| OSDParser::deserialize_llsd_xml_with_bytes(bytes)
+    OSDParser::deserialize_llsd_xml_with_bytes
 );
 llsd_workload!(
     llsd_binary,
     |value: &OSD| OSDParser::serialize_llsd_binary_with_osd(value.clone()),
-    |bytes| OSDParser::deserialize_llsd_binary_with_bytes(bytes)
+    OSDParser::deserialize_llsd_binary_with_bytes
 );
 llsd_workload!(
     llsd_protobuf,
     |value: &OSD| OSDParser::serialize_llsd_protobuf(value.clone(), Some(true)),
-    |bytes| OSDParser::deserialize_llsd_protobuf_with_bytes(bytes)
+    OSDParser::deserialize_llsd_protobuf_with_bytes
 );
 
 fn llsd_json(context: &Context, iterations: usize) -> AppResult<u64> {
@@ -612,7 +613,7 @@ fn inventory_update(context: &Context, iterations: usize) -> AppResult<u64> {
         item.base.set_name(format!("item-{index}"));
         store.update_node_for(&item).map_err(debug)?;
     }
-    Ok(u64::try_from(store.count()).map_err(debug)?)
+    u64::try_from(store.count()).map_err(debug)
 }
 
 fn object_update(context: &Context, iterations: usize) -> AppResult<u64> {
@@ -923,8 +924,10 @@ fn hash_file(path: &Path) -> AppResult<String> {
     let bytes = fs::read(path).map_err(|error| format!("read {}: {error}", path.display()))?;
     Ok(Sha256::digest(bytes)
         .iter()
-        .map(|byte| format!("{byte:02x}"))
-        .collect())
+        .fold(String::with_capacity(64), |mut output, byte| {
+            write!(output, "{byte:02x}").expect("writing to a String is infallible");
+            output
+        }))
 }
 
 fn read_json<T: for<'de> Deserialize<'de>>(path: &Path) -> AppResult<T> {
@@ -965,6 +968,7 @@ fn debug(error: impl std::fmt::Debug) -> String {
 }
 
 #[cfg(test)]
+#[allow(clippy::float_cmp)] // Metrics use exact integer-derived values in these tests.
 mod tests {
     use super::*;