Complete first release candidate audit (#107)

crates/libremetaverse/tests/generated_event_args.rs

@@ -0,0 +1,57 @@
+//! Behavioral checks for immutable event-argument mappings generated from the
+//! pinned C# constructor assignments.
+
+#![allow(clippy::float_cmp)] // Generated constructor fixtures retain exact values.
+
+use libremetaverse::{MeanCollisionEventArgs, MeanCollisionType, ScriptDialogEventArgs};
+use libremetaverse_types::UUID;
+use std::time::{Duration, UNIX_EPOCH};
+
+fn id(value: u64) -> UUID {
+    UUID::new_with_u_int64(value).expect("UUID")
+}
+
+#[test]
+fn script_dialog_preserves_constructor_values_and_aliases() {
+    let image_id = id(1);
+    let object_id = id(2);
+    let owner_id = id(3);
+    let dialog = ScriptDialogEventArgs::new(
+        "Choose".to_owned(),
+        "OpenSim object".to_owned(),
+        image_id,
+        object_id,
+        "Grid".to_owned(),
+        "Resident".to_owned(),
+        -42,
+        vec!["Yes".to_owned(), "No".to_owned()],
+        owner_id,
+    )
+    .expect("ScriptDialogEventArgs");
+
+    assert_eq!(dialog.message(), "Choose");
+    assert_eq!(dialog.object_name(), "OpenSim object");
+    assert_eq!(dialog.image_id(), image_id);
+    assert_eq!(dialog.object_id(), object_id);
+    assert_eq!(dialog.first_name(), "Grid");
+    assert_eq!(dialog.last_name(), "Resident");
+    assert_eq!(dialog.channel(), -42);
+    assert_eq!(dialog.button_labels(), ["Yes", "No"]);
+    assert_eq!(dialog.owner_id(), owner_id);
+}
+
+#[test]
+fn mean_collision_maps_perp_to_aggressor() {
+    let aggressor = id(10);
+    let victim = id(11);
+    let time = UNIX_EPOCH + Duration::from_secs(1234);
+    let collision =
+        MeanCollisionEventArgs::new(MeanCollisionType::Bump, aggressor, victim, 2.5, time)
+            .expect("MeanCollisionEventArgs");
+
+    assert_eq!(collision.type_(), MeanCollisionType::Bump);
+    assert_eq!(collision.aggressor(), aggressor);
+    assert_eq!(collision.victim(), victim);
+    assert_eq!(collision.magnitude(), 2.5);
+    assert_eq!(collision.time(), time);
+}

crates/libremetaverse/tests/network_manager.rs

@@ -1,3 +1,8 @@
+#![allow(clippy::await_holding_lock)] // The process-wide guard serializes socket integration tests.
+#![allow(clippy::float_cmp)] // Wire fixtures use exactly representable values.
+#![allow(clippy::items_after_statements)] // Local constants stay next to their concurrency scenario.
+#![allow(clippy::too_many_lines)] // End-to-end fixtures keep each protocol exchange contiguous.
+
 use libremetaverse::http::DownloadManager;
 use libremetaverse::interfaces::IMessage;
 use libremetaverse::messages::linden::{
@@ -14,7 +19,7 @@ use libremetaverse::{
     InventoryItem, LoginState, LoginStatus, NetworkManager, NetworkManagerDisconnectType,
     NetworkManagerLoginResponseCallback, PacketEventDictionary, Simulator,
 };
-use libremetaverse_structured_data::{OSD, OSDParser};
+use libremetaverse_structured_data::{OSD, OSDMap, OSDParser};
 use libremetaverse_types::compat::{
     CancellationTokenSource, EventHandler, HttpMessageHandler, HttpRequest, HttpResponse, Uri,
 };
@@ -287,7 +292,15 @@ fn abort_and_callback_unregistration_preserve_reference_noop_behavior() {
 }
 
 struct TestCapsMessage;
-impl IMessage for TestCapsMessage {}
+impl IMessage for TestCapsMessage {
+    fn deserialize(&mut self, _map: OSDMap) -> Result<(), Error> {
+        Ok(())
+    }
+
+    fn serialize(&self) -> Result<OSDMap, Error> {
+        OSDMap::new_with_constructor()
+    }
+}
 
 #[test]
 fn caps_callbacks_are_ordered_and_subscription_guards_unregister() {