Add fields with name PIN as sensitive info #81

Closed
opened 2026-08-12 17:18:33 +00:00 by hugo · 1 comment
Owner

Treat fields with the name PIN (ignoring the actual case of letters) as a sensitive field, just like password. So a user has to click the reveal icon to see it, preventing actual leaking it by just selecting an entry with such a field.

Treat fields with the name PIN (ignoring the actual case of letters) as a sensitive field, just like password. So a user has to click the reveal icon to see it, preventing actual leaking it by just selecting an entry with such a field.
hugo added this to the 04 - iPhone and Apple Watch apps milestone 2026-08-12 17:18:33 +00:00
hugo added the bugcritical labels 2026-08-12 17:18:33 +00:00
Author
Owner

Implemented in b5571fc. PIN-named fields are now classified as sensitive case-insensitively in the shared Rust document model, and the mobile editor derives masking from that sensitivity metadata. Added regression coverage for PIN, pin, and PiN across storage classification, mobile display masking/reveal behavior, selectability, and editor masking.

Verification: cargo fmt --all -- --check; RUSTFLAGS=-D warnings cargo check --workspace --all-targets; cargo clippy --workspace --all-targets -- -D warnings; cargo test --workspace; xcodegen generate; iPhone 17 Pro Simulator Debug build. In Simulator, the existing PIN field displayed as Hidden, revealed only after the Reveal field control was actually activated, and returned to Hidden after Hide field. A signed Release build also succeeded and was installed over the existing app on the paired iPhone without uninstalling it.

Implemented in b5571fc. PIN-named fields are now classified as sensitive case-insensitively in the shared Rust document model, and the mobile editor derives masking from that sensitivity metadata. Added regression coverage for PIN, pin, and PiN across storage classification, mobile display masking/reveal behavior, selectability, and editor masking. Verification: cargo fmt --all -- --check; RUSTFLAGS=-D warnings cargo check --workspace --all-targets; cargo clippy --workspace --all-targets -- -D warnings; cargo test --workspace; xcodegen generate; iPhone 17 Pro Simulator Debug build. In Simulator, the existing PIN field displayed as Hidden, revealed only after the Reveal field control was actually activated, and returned to Hidden after Hide field. A signed Release build also succeeded and was installed over the existing app on the paired iPhone without uninstalling it.
hugo closed this issue 2026-08-12 18:11:43 +00:00
Sign in to join this conversation.