Changes that are just renames seem to not go out #124

Closed
opened 2026-09-12 10:34:59 +00:00 by hugo · 1 comment
Owner

I have two changes on my local iPhone that are just a move and a move back (two renames) and on sync they do not go out.

I have two changes on my local iPhone that are just a move and a move back (two renames) and on sync they do not go out.
hugo added the bugcritical labels 2026-09-12 10:34:59 +00:00
Author
Owner

Confirmed with the reporter: explicitly choosing Push successfully uploaded both rename commits. The cause was the Home pull-down gesture performing Pull only, while Push was hidden in swipe/context actions.

Implemented in aec3f23 (v1.0.1, Apple build 8):

  • Pulling down on Home now invokes storage-owned sync: Pull first, then Push only when Pull succeeds.
  • Pull errors, including authentication/network failures and merge conflicts, are surfaced to the user and stop the push step. Sync interruptions are shown as errors too.
  • Existing explicit Pull and Push actions remain available. Local views are invalidated even if a successful pull is followed by a failed push.
  • Added regression coverage for move-and-move-back commits with an unchanged final tree, plus failed-pull/no-push coverage.

Validation: cargo fmt, warnings-denied workspace check, clippy, and all workspace tests passed. iPhone and Watch simulator builds passed; the existing simulator app was updated in place. Live account sync is deferred to the reporter's TestFlight test as requested. No paired physical iPhone installation was performed.

TestFlight 1.0.1 (8) has been uploaded, processed by Apple, and assigned to the existing Internal Testing group. Test notes are saved. The tagged patch-release pipeline is still building its desktop/CLI packages.

Confirmed with the reporter: explicitly choosing Push successfully uploaded both rename commits. The cause was the Home pull-down gesture performing Pull only, while Push was hidden in swipe/context actions. Implemented in aec3f23 (v1.0.1, Apple build 8): - Pulling down on Home now invokes storage-owned sync: Pull first, then Push only when Pull succeeds. - Pull errors, including authentication/network failures and merge conflicts, are surfaced to the user and stop the push step. Sync interruptions are shown as errors too. - Existing explicit Pull and Push actions remain available. Local views are invalidated even if a successful pull is followed by a failed push. - Added regression coverage for move-and-move-back commits with an unchanged final tree, plus failed-pull/no-push coverage. Validation: cargo fmt, warnings-denied workspace check, clippy, and all workspace tests passed. iPhone and Watch simulator builds passed; the existing simulator app was updated in place. Live account sync is deferred to the reporter's TestFlight test as requested. No paired physical iPhone installation was performed. TestFlight 1.0.1 (8) has been uploaded, processed by Apple, and assigned to the existing Internal Testing group. Test notes are saved. The tagged patch-release pipeline is still building its desktop/CLI packages.
hugo closed this issue 2026-09-12 12:38:41 +00:00
Sign in to join this conversation.