hugo/IronStorage
1
0
Fork 0
Code Issues 28 Pull Requests Actions Packages Projects Releases Wiki Activity

Refine implementation findings
Some checks failed
Dependency security audit / rustsec (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Chili Palmer
2026-08-27 14:59:17 +02:00
parent 4c5ed4baf6
commit 2feecae70d
1 changed files with 10 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
FINDINGS.md
View File

@@ -39,13 +39,16 @@ proves one snapshot is taken for a directory operation.
`crates/storage/src/git.rs` classify authentication, TLS, and network failures `crates/storage/src/git.rs` classify authentication, TLS, and network failures
using substrings from third-party error messages. using substrings from third-party error messages.
Use structured `reqwest` status/connect/timeout information and matchable `gix` Use structured `reqwest` status/connect/timeout information, error sources, and
error variants wherever available. Keep a bounded textual diagnostic only as a matchable `gix` variants wherever available. Classify TLS only when a structured
fallback; it must not drive a more specific classification unless the library source identifies it. When `gix` has erased the underlying status or cause,
exposes no structured alternative. return a generic error with a bounded diagnostic instead of guessing a specific
class from rendered text.
Acceptance: tests classify HTTP 401/403, TLS failure, connection/timeout, and an Acceptance: tests classify direct HTTP 401/403 and structured connection,
unknown protocol failure without depending on English error text. timeout, and TLS failures without depending on English error text. A `gix`
failure without a structured cause remains generic and its diagnostic is
bounded.
## 4. Make config replacement durable ## 4. Make config replacement durable
@@ -59,20 +62,7 @@ if the rename succeeds but the directory sync fails.
Acceptance: focused tests cover the post-rename sync failure boundary. Do not Acceptance: focused tests cover the post-rename sync failure boundary. Do not
add config locking unless concurrent writers are an explicit supported use case. add config locking unless concurrent writers are an explicit supported use case.
## 5. Do not hold secret-store state across backend I/O ## 5. Reap completed TUI task handles
`SecretStore` in `crates/storage/src/secret_store.rs` holds its mutex while
calling potentially blocking backend operations (`unlock`, `lock`, `create`,
`retrieve`, `replace`, and `delete`).
Reduce the lock scope around backend calls while preserving atomic lock-state
and cache behavior. Do not weaken biometric/keychain protection or allow a
secret operation to complete as unlocked after a concurrent `lock()`.
Acceptance: concurrency tests cover `lock()` racing with at least retrieval and
mutation, and prove no stale secret is inserted into the cache.
## 6. Reap completed TUI task handles
`AsyncExecutor::submit` in `apps/tui/src/runtime.rs` retains every `JoinHandle` `AsyncExecutor::submit` in `apps/tui/src/runtime.rs` retains every `JoinHandle`
until executor drop. until executor drop.