in the TUI, a "q" is supposed to close the app, not just the last pane #58

Closed
opened 2026-08-03 20:52:54 +00:00 by hugo · 1 comment
Owner

right now "q" kinda behaves like backspace in that it goes one back, but "q" should just exit the app.

right now "q" kinda behaves like backspace in that it goes one back, but "q" should just exit the app.
hugo added this to the first feature complete release milestone 2026-08-03 20:52:54 +00:00
hugo added the bug label 2026-08-03 20:52:54 +00:00
Author
Owner

Implemented in ccaa920.

  • q now exits the TUI from every non-editor state, including nested panes and confirmation overlays.
  • Editors still accept q as normal text input.
  • Escape and Backspace retain their existing back/cancel behavior.
  • Built-in help now describes q unambiguously as quit.
  • Added a regression test proving nested history is not popped and a confirmation is not merely dismissed.

Verification:

  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo check --workspace --all-targets
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace (45 tests)
  • Interactive PTY session: opened a repository commit pane with navigation history, pressed q, and confirmed immediate clean process exit instead of back navigation

This is TUI-only, so no iPhone release build was performed as requested.

Implemented in `ccaa920`. - `q` now exits the TUI from every non-editor state, including nested panes and confirmation overlays. - Editors still accept `q` as normal text input. - Escape and Backspace retain their existing back/cancel behavior. - Built-in help now describes `q` unambiguously as quit. - Added a regression test proving nested history is not popped and a confirmation is not merely dismissed. Verification: - `cargo fmt --all -- --check` - `RUSTFLAGS="-D warnings" cargo check --workspace --all-targets` - `cargo clippy --workspace --all-targets -- -D warnings` - `cargo test --workspace` (45 tests) - Interactive PTY session: opened a repository commit pane with navigation history, pressed `q`, and confirmed immediate clean process exit instead of back navigation This is TUI-only, so no iPhone release build was performed as requested.
hugo closed this issue 2026-08-04 16:50:36 +00:00
Sign in to join this conversation.