hugo/Gotcha
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

Close open milestones from the iPhone app #47

New Issue
Closed
opened 2026-07-31 21:17:28 +00:00 by hugo · 1 comment
hugo commented 2026-07-31 21:17:28 +00:00
Owner
Copy Link

The iPhone app should be able to close a milestone. Check if the API has that available - I only know the „close“ button in the UI. If we can open/close freely, add a checkbox to the editor for milestones.

The iPhone app should be able to close a milestone. Check if the API has that available - I only know the „close“ button in the UI. If we can open/close freely, add a checkbox to the editor for milestones.
hugo added this to the first feature complete release milestone 2026-07-31 21:17:28 +00:00
hugo added the enhancement label 2026-07-31 21:17:28 +00:00
hugo commented 2026-08-01 13:00:24 +00:00
Author
Owner
Copy Link

Implemented in 047f0ab.

  • Added typed Gitea milestone state handling with explicit open/closed validation and serialization.
  • Added a native, accessible Closed switch to the milestone editor. Existing state loads into the editor, new milestones default open, and Save can close or reopen a milestone.
  • Kept the state mapping in Rust, regenerated the UniFFI Swift/C bindings, and updated TESTING.md with close, reopen, persistence, Cancel, Dynamic Type, and VoiceOver coverage.

Verification:

  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo check --workspace --all-targets
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace (31 tests passed)
  • Signed iPhone 17 Pro Simulator build passed.
  • On the live milestone, closed it from the iPhone UI, confirmed the closed detail state, reopened it from the editor, and confirmed the server reports it open again.
  • Verified the editor and Cancel behavior at accessibility-extra-extra-extra-large; VoiceOver exposes the switch label and on/off value.
Implemented in `047f0ab`. - Added typed Gitea milestone state handling with explicit `open`/`closed` validation and serialization. - Added a native, accessible **Closed** switch to the milestone editor. Existing state loads into the editor, new milestones default open, and Save can close or reopen a milestone. - Kept the state mapping in Rust, regenerated the UniFFI Swift/C bindings, and updated `TESTING.md` with close, reopen, persistence, Cancel, Dynamic Type, and VoiceOver coverage. Verification: - `cargo fmt --all -- --check` - `RUSTFLAGS="-D warnings" cargo check --workspace --all-targets` - `cargo clippy --workspace --all-targets -- -D warnings` - `cargo test --workspace` (31 tests passed) - Signed iPhone 17 Pro Simulator build passed. - On the live milestone, closed it from the iPhone UI, confirmed the closed detail state, reopened it from the editor, and confirmed the server reports it open again. - Verified the editor and Cancel behavior at `accessibility-extra-extra-extra-large`; VoiceOver exposes the switch label and on/off value.
hugo closed this issue 2026-08-01 13:00:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 critical
critical issues that take precendence over others of the same grouping
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 idea
an idea for a future milestone
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone first feature complete release
Projects
Clear projects
No project
Assignees
Clear assignees
hugo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hugo/Gotcha#47
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?