hugo/Gotcha
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

Open/closed status also for milestones and pull requests #38

New Issue
Closed
opened 2026-07-31 16:03:43 +00:00 by hugo · 1 comment
hugo commented 2026-07-31 16:03:43 +00:00
Owner
Copy Link

Milestones and pull request also have an open / closed status and that should be denoted in lists and details in the same way as it is done for issues.

Milestones and pull request also have an open / closed status and that should be denoted in lists and details in the same way as it is done for issues.
hugo added this to the first feature complete release milestone 2026-07-31 16:03:43 +00:00
hugo added the enhancement label 2026-07-31 16:03:43 +00:00
hugo commented 2026-07-31 16:39:47 +00:00
Author
Owner
Copy Link

Implemented in commit 128be97.

  • Added view-ready open/closed state to milestone rows, pull-request rows, and pull-request details in Rust, with generated UniFFI bindings updated.
  • Added native adaptive pull-request cells and reused the app's state presentation for milestone and pull-request lists/details: green open icons, purple closed icons, and subject-specific VoiceOver labels.
  • Updated TESTING.md for the new visual and accessibility behavior.

Verification completed in isolation:

  • cargo fmt --all -- --check
  • RUSTFLAGS="-D warnings" cargo check --workspace --all-targets
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace (28 tests passed)
  • Final iPhone 17 Pro simulator build succeeded.
  • Manual simulator checks passed for closed pull-request list/detail state, open milestone list/detail state, and their VoiceOver labels. The connected repository had no open pull requests or closed milestones; those complementary state branches use the same shared renderer and are covered by Rust state-propagation tests.
Implemented in commit `128be97`. - Added view-ready open/closed state to milestone rows, pull-request rows, and pull-request details in Rust, with generated UniFFI bindings updated. - Added native adaptive pull-request cells and reused the app's state presentation for milestone and pull-request lists/details: green open icons, purple closed icons, and subject-specific VoiceOver labels. - Updated `TESTING.md` for the new visual and accessibility behavior. Verification completed in isolation: - `cargo fmt --all -- --check` - `RUSTFLAGS="-D warnings" cargo check --workspace --all-targets` - `cargo clippy --workspace --all-targets -- -D warnings` - `cargo test --workspace` (28 tests passed) - Final iPhone 17 Pro simulator build succeeded. - Manual simulator checks passed for closed pull-request list/detail state, open milestone list/detail state, and their VoiceOver labels. The connected repository had no open pull requests or closed milestones; those complementary state branches use the same shared renderer and are covered by Rust state-propagation tests.
hugo closed this issue 2026-07-31 16:39:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 critical
critical issues that take precendence over others of the same grouping
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 idea
an idea for a future milestone
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label enhancement
Milestone
No items
No Milestone first feature complete release
Projects
Clear projects
No project
Assignees
Clear assignees
hugo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hugo/Gotcha#38
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?