hugo/Gotcha
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

Branch connections are cluttered and straight #36

New Issue
Closed
opened 2026-07-31 14:56:08 +00:00 by hugo · 1 comment
hugo commented 2026-07-31 14:56:08 +00:00
Owner
Copy Link

Branch connections (branching off another branch or merging back) must be properly aligned and rounded, not angular. Make a proper visual check for them to make sure you get it right.

Branch connections (branching off another branch or merging back) must be properly aligned and rounded, not angular. Make a proper visual check for them to make sure you get it right.
hugo added this to the first feature complete release milestone 2026-07-31 14:56:08 +00:00
hugo added the bug label 2026-07-31 14:56:08 +00:00
hugo commented 2026-07-31 15:44:41 +00:00
Author
Owner
Copy Link

Implemented in eadbadd.

  • Split commit-graph connections into Rust-owned incoming merge and outgoing branch edges instead of flattening them into undirected horizontal segments.
  • Propagated the view-ready directional graph data through the app and regenerated UniFFI bindings.
  • Replaced angular horizontal bars with native cubic curves whose vertical tangents meet the correct commit node and lane boundary; increased lane spacing and reserved the full graph width so graph and text do not overlap.
  • Expanded graph-layout coverage to assert both a branch-out and a merge-back edge.

Verified against DS4Server's real multi-branch history in the iPhone 17 Pro simulator: both the branch-out and merge-back curves are smooth and correctly aligned, lanes remain continuous while scrolling, and switching between All and main updates the graph correctly. The simulator build and all required formatting, warning-free check, Clippy, and workspace test gates passed.

Implemented in eadbadd. - Split commit-graph connections into Rust-owned incoming merge and outgoing branch edges instead of flattening them into undirected horizontal segments. - Propagated the view-ready directional graph data through the app and regenerated UniFFI bindings. - Replaced angular horizontal bars with native cubic curves whose vertical tangents meet the correct commit node and lane boundary; increased lane spacing and reserved the full graph width so graph and text do not overlap. - Expanded graph-layout coverage to assert both a branch-out and a merge-back edge. Verified against DS4Server's real multi-branch history in the iPhone 17 Pro simulator: both the branch-out and merge-back curves are smooth and correctly aligned, lanes remain continuous while scrolling, and switching between All and main updates the graph correctly. The simulator build and all required formatting, warning-free check, Clippy, and workspace test gates passed.
hugo closed this issue 2026-07-31 15:44:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 critical
critical issues that take precendence over others of the same grouping
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 idea
an idea for a future milestone
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone first feature complete release
Projects
Clear projects
No project
Assignees
Clear assignees
hugo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hugo/Gotcha#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?