hugo/Gotcha
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

File list for pull requests must look like file lists for commits #32

New Issue
Closed
opened 2026-07-31 14:44:29 +00:00 by hugo · 1 comment
hugo commented 2026-07-31 14:44:29 +00:00
Owner
Copy Link

There is a different styling for the file list on pull request details but that must be the same as with commits. UI needs to be coherent in style.

There is a different styling for the file list on pull request details but that must be the same as with commits. UI needs to be coherent in style.
hugo added this to the first feature complete release milestone 2026-07-31 14:44:29 +00:00
hugo added the bug label 2026-07-31 14:44:29 +00:00
hugo commented 2026-07-31 15:22:07 +00:00
Author
Owner
Copy Link

Implemented in 822cf1f.

  • Replaced the pull-request detail's ad-hoc blue file buttons with a native non-scrolling UITableView section.
  • Pull-request and commit file rows now use the same FileRow data and configureTextCell presentation path: left-aligned paths, secondary statuses, full-width separators, disclosure indicators, and native selection behavior.
  • Automatic row sizing preserves Dynamic Type and long paths, while the detail page remains the sole scroll surface; tapping a row still opens the pull diff.
  • Updated TESTING.md with the explicit commit/pull file-list parity checks.

Verified in isolation with the full required gate suite (cargo fmt, warning-free workspace check, Clippy with warnings denied, and all workspace tests), a signed arm64 iPhone 17 Pro simulator build, and manual simulator checks of path/status rendering, separators, disclosure indicators, scrolling, accessibility output, and diff navigation.

Implemented in 822cf1f. - Replaced the pull-request detail's ad-hoc blue file buttons with a native non-scrolling `UITableView` section. - Pull-request and commit file rows now use the same `FileRow` data and `configureTextCell` presentation path: left-aligned paths, secondary statuses, full-width separators, disclosure indicators, and native selection behavior. - Automatic row sizing preserves Dynamic Type and long paths, while the detail page remains the sole scroll surface; tapping a row still opens the pull diff. - Updated `TESTING.md` with the explicit commit/pull file-list parity checks. Verified in isolation with the full required gate suite (`cargo fmt`, warning-free workspace check, Clippy with warnings denied, and all workspace tests), a signed arm64 iPhone 17 Pro simulator build, and manual simulator checks of path/status rendering, separators, disclosure indicators, scrolling, accessibility output, and diff navigation.
hugo closed this issue 2026-07-31 15:22:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 critical
critical issues that take precendence over others of the same grouping
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 idea
an idea for a future milestone
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone first feature complete release
Projects
Clear projects
No project
Assignees
Clear assignees
hugo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hugo/Gotcha#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?