review proper structure of code and distribution of function to rust or swift #21
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The full functionality of the app, the actual code that executes function needs to be Rust. Swift is only there to handle the UI itself. So the code has to be reviewed to make sure that we not only follow best practices for both Rust and Swift, but also make sure that Swift code is really only handling the UI areas and we don't put functionality into Swift "just because that file was open". there is a deliberate decision on where code has to be done and we must follow that.
It needs to be codified in AGENTS.md that we have this distinction of what code is in what language and we need to do a proper review of existing code to make sure it is following that structure.
review proper structure of code and distribution of function to rust or wiftto review proper structure of code and distribution of function to rust or swiftImplemented in
a2615d5. Codified the Rust/Swift ownership boundary in AGENTS.md and audited every iOS Swift source. Moved issue-filter state and unavailable-choice handling, Home activity categorization and nine-calendar-month contribution aggregation, milestone progress, pull/commit display formatting, repository path titles, and repository file decoding/classification/language detection into the Rust application layer. Regenerated the UniFFI Swift/C bridge and added Rust coverage for filter defaults/options, activity categories, calendar heatmap range, milestone progress, and Markdown/source/image/PDF/audio/video classification. Verification passed: cargo fmt --check, warnings-as-errors cargo check, Clippy with warnings denied, full workspace tests, signed arm64 iPhone 17 Pro simulator build, and live affected TESTING.md scenarios for Home filters, issue filters/default state, milestones/accessibility, pull rows, commit rows, nested file navigation, Markdown preview/source, Swift and Rust highlighting, and native image Quick Look.