hugo/DS4Server
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

deleting a session needs a confirmation dialog #32

New Issue
Closed
opened 2026-07-26 15:53:11 +00:00 by hugo · 1 comment
hugo commented 2026-07-26 15:53:11 +00:00
Owner
Copy Link

when deleting a session, a confirmation dialog needs to pop up that has to be confirmed before the session is actually deleted. this holds true for any way to delete a session.

when deleting a session, a confirmation dialog needs to pop up that has to be confirmed before the session is actually deleted. this holds true for any way to delete a session.
hugo added the bug label 2026-07-26 15:53:11 +00:00
hugo added the critical label 2026-07-26 15:55:28 +00:00
hugo commented 2026-07-27 12:18:52 +00:00
Author
Owner
Copy Link

Implemented in commit a90a241. Every stored-session delete action now opens a confirmation dialog; Cancel or Escape dismisses it without changing data, and only the separate confirmation action reaches the existing database deletion path. The dialog reuses the shared modal surface and destructive-button styles. Verified with rustfmt, Clippy, make bundle, and cargo test --all-features (113 passed, 12 hardware-dependent ignored).

Implemented in commit a90a241. Every stored-session delete action now opens a confirmation dialog; Cancel or Escape dismisses it without changing data, and only the separate confirmation action reaches the existing database deletion path. The dialog reuses the shared modal surface and destructive-button styles. Verified with rustfmt, Clippy, make bundle, and cargo test --all-features (113 passed, 12 hardware-dependent ignored).
hugo closed this issue 2026-07-27 12:18:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
cannot reproduce
bug
Something is not working
 critical
issues that are more important than others of the same group
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 idea
just an idea
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug critical
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hugo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hugo/DS4Server#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?