diff --git a/AUDIT.md b/AUDIT.md index e7d303e..a2486ef 100644 --- a/AUDIT.md +++ b/AUDIT.md @@ -44,6 +44,7 @@ after each item. - [x] `desktop/server.ex` - [x] `desktop/shell_live/code_entity_editor.ex` - [x] `scripting/runtime.ex` +- [x] `desktop/external_links.ex` --- diff --git a/lib/bds/desktop/external_links.ex b/lib/bds/desktop/external_links.ex deleted file mode 100644 index 16fccc8..0000000 --- a/lib/bds/desktop/external_links.ex +++ /dev/null @@ -1,12 +0,0 @@ -defmodule BDS.Desktop.ExternalLinks do - @moduledoc false - - @github_url "https://github.com/rfc1437/bDS2" - @github_issues_url "#{@github_url}/issues" - - @spec github_url() :: String.t() - def github_url, do: @github_url - - @spec github_issues_url() :: String.t() - def github_issues_url, do: @github_issues_url -end diff --git a/lib/bds/desktop/menu_bar.ex b/lib/bds/desktop/menu_bar.ex index 8080274..1ae52d1 100644 --- a/lib/bds/desktop/menu_bar.ex +++ b/lib/bds/desktop/menu_bar.ex @@ -2,7 +2,7 @@ defmodule BDS.Desktop.MenuBar do @moduledoc false use BDS.Desktop.MenuCompat - alias BDS.Desktop.{ExternalLinks, ShellData, Shutdown, UILocale} + alias BDS.Desktop.{ShellData, Shutdown, UILocale} alias BDS.UI.Commands alias BDS.UI.MenuBar, as: ShellMenuBar alias Desktop.OS @@ -59,7 +59,7 @@ defmodule BDS.Desktop.MenuBar do end def handle_event("view_on_github", menu) do - OS.launch_default_browser(ExternalLinks.github_url()) + OS.launch_default_browser("https://github.com/rfc1437/bDS2") {:noreply, menu} end @@ -78,7 +78,7 @@ defmodule BDS.Desktop.MenuBar do end def handle_event("report_issue", menu) do - OS.launch_default_browser(ExternalLinks.github_issues_url()) + OS.launch_default_browser("https://github.com/rfc1437/bDS2/issues") {:noreply, menu} end diff --git a/lib/bds/desktop/shell_live.ex b/lib/bds/desktop/shell_live.ex index 0e2b090..6c9896d 100644 --- a/lib/bds/desktop/shell_live.ex +++ b/lib/bds/desktop/shell_live.ex @@ -7,7 +7,7 @@ defmodule BDS.Desktop.ShellLive do alias BDS.{AI, Blogmark, BoundedAtoms, Metadata} alias BDS.CliSync.Watcher - alias BDS.Desktop.{ExternalLinks, FilePicker, FolderPicker, ShellData, UILocale} + alias BDS.Desktop.{FilePicker, FolderPicker, ShellData, UILocale} alias BDS.Desktop.ShellLive.{ Bridges, @@ -1326,12 +1326,12 @@ defmodule BDS.Desktop.ShellLive do end defp handle_socket_menu_action(socket, :view_on_github) do - OS.launch_default_browser(ExternalLinks.github_url()) + OS.launch_default_browser("https://github.com/rfc1437/bDS2") socket end defp handle_socket_menu_action(socket, :report_issue) do - OS.launch_default_browser(ExternalLinks.github_issues_url()) + OS.launch_default_browser("https://github.com/rfc1437/bDS2/issues") socket end diff --git a/test/bds/desktop_test.exs b/test/bds/desktop_test.exs index bed23e3..4394a86 100644 --- a/test/bds/desktop_test.exs +++ b/test/bds/desktop_test.exs @@ -169,13 +169,6 @@ defmodule BDS.DesktopTest do assert_receive :quit_requested end - test "desktop external links point at the bDS2 GitHub project and issue tracker" do - assert BDS.Desktop.ExternalLinks.github_url() == "https://github.com/rfc1437/bDS2" - - assert BDS.Desktop.ExternalLinks.github_issues_url() == - "https://github.com/rfc1437/bDS2/issues" - end - test "icon menu quit requests app-owned shutdown" do previous_module = Application.get_env(:bds, :desktop_shutdown_module) previous_pid = Application.get_env(:bds, :desktop_shutdown_test_pid)