From c7850484068b7870b9f57db918eefb8d7f355e1e Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 15 Feb 2026 10:53:22 +0000
Subject: [PATCH] Address code review feedback - improve test cleanup and
 remove redundant test

Co-authored-by: rfc1437 <774975+rfc1437@users.noreply.github.com>
---
 tests/engine/TagEngine.test.ts | 26 ++++++++++++++++++++++++--
 tests/engine/stemmer.test.ts   |  4 ----
 2 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/tests/engine/TagEngine.test.ts b/tests/engine/TagEngine.test.ts
index 75dd865..0f0e1e4 100644
--- a/tests/engine/TagEngine.test.ts
+++ b/tests/engine/TagEngine.test.ts
@@ -613,16 +613,38 @@ describe('TagEngine', () => {
     });
 
     it('should return empty array when client is not available', async () => {
+      // Store original mock implementation
+      const originalMock = vi.mocked(getDatabase).getMockImplementation();
+      
       // Mock getClient to return null
-      const mockGetClient = vi.fn().mockReturnValue(null);
       vi.mocked(getDatabase).mockReturnValue({
         getLocal: vi.fn(() => mockLocalDb),
-        getLocalClient: mockGetClient,
+        getLocalClient: vi.fn().mockReturnValue(null),
       } as any);
 
       const result = await tagEngine.getPostsWithTag('tag-1');
 
       expect(result).toEqual([]);
+      
+      // Restore original mock
+      if (originalMock) {
+        vi.mocked(getDatabase).mockImplementation(originalMock);
+      } else {
+        // Restore to standard mock
+        vi.mocked(getDatabase).mockReturnValue({
+          getLocal: vi.fn(() => mockLocalDb),
+          getLocalClient: vi.fn(() => mockLocalClient),
+          getRemote: vi.fn(() => null),
+          getDataPaths: vi.fn(() => ({
+            database: '/mock/userData/bds.db',
+            posts: '/mock/userData/posts',
+            media: '/mock/userData/media',
+          })),
+          initializeLocal: vi.fn(),
+          initializeRemote: vi.fn(),
+          close: vi.fn(),
+        } as any);
+      }
     });
   });
 });
diff --git a/tests/engine/stemmer.test.ts b/tests/engine/stemmer.test.ts
index 1212259..df6a018 100644
--- a/tests/engine/stemmer.test.ts
+++ b/tests/engine/stemmer.test.ts
@@ -137,10 +137,6 @@ describe('stemmer', () => {
       expect(stemText('   ', 'english')).toBe('');
     });
 
-    it('should return empty string for null/undefined-like empty text', () => {
-      expect(stemText('', 'english')).toBe('');
-    });
-
     it('should handle multiple spaces between words', () => {
       const result = stemText('Running   dogs   are   playing', 'english');
       const words = result.split(' ');